Adjust widget form margins in the new widget editor#33040
Merged
Conversation
|
Size Change: +205 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
Member
|
I tested this PR and I am seeing missing arrow and clipped drop down.
|
Member
|
Two line of CSS fixed the clipping issue. Change background to background-colour and remove height on css. |
Member
|
The css rule is only for input[type=text], select, what about other input text types like these. |
Contributor
Author
|
Great feedback @spacedmonkey, your suggestions make sense and I included them in the PR. |
Member
|
@adamziel The arrow disappears when focused when 2021 theme is active.
Not an issue in different themes.
|
Member
|
Also worth noting that I tested with another widget and it looks soooo much better. |
Member
|
Thanks for jumping on this. We forgot the |
youknowriad
pushed a commit
that referenced
this pull request
Jun 29, 2021
* Adjust widget form margins in the new widget editor * Adjust the selector to cover more input types, change background to background-color
Contributor
Author
|
@spacedmonkey here's the follow-up issue to fix the missing dropdown icon: https://core.trac.wordpress.org/ticket/53560 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #32955
The widgets editor suffers from a few CSS inconsistencies, this is especially visible when changing themes.
On Twenty Twenty One
There is very little spacing between labels and form fields due to a low line-height value:
On Twenty Twenty
The spacing between form rows is quite large, this is especially visible with checkboxes:
Each checkbox is wrapped a separate
<p>and is a subject to the same margin as all other paragraphs. I think the only generic way of solving that is setting that margin to a lower value like10px.On both
The first input has a left padding inconsistent with other inputs and selects:
How has this been tested?
Screenshots
Twenty Twenty One:
Twenty Twenty:
Types of changes
Bug fix (non-breaking change which fixes an issue)