[E2E Tests]: Fix WP editor metabox test#32915
Merged
Conversation
7 tasks
|
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
gziolo
reviewed
Jun 23, 2021
Member
gziolo
left a comment
There was a problem hiding this comment.
Thank you for investigating this test failure. I think is fine to update the test with how it works, but we need to figure out what has changed in the WordPress core that triggered this change in behavior.
@youknowriad or @noisysocks, any ideas?
gziolo
approved these changes
Jun 23, 2021
Member
|
So it looks like the wrapping |
443ed94 to
d08438e
Compare
youknowriad
pushed a commit
that referenced
this pull request
Jun 24, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jun 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
toMatchSnapshotwithtoMatchInlineSnapshotto make tests more readable.I did manual testing and always saw wrapping
<p>when getting value from TinyMCE editor.How has this been tested?
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).