Block Library: Ensure there is no direct import from core/editor store#32866
Merged
Block Library: Ensure there is no direct import from core/editor store#32866
Conversation
|
Size Change: -17 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
noisysocks
approved these changes
Jun 22, 2021
Member
noisysocks
left a comment
There was a problem hiding this comment.
Looks good, thanks for fixing. These blocks are removed during tree shaking in wordpress-develop so this change is really just to make the linter happy.
Member
Author
|
@youknowriad, this one is ready to backport. It should make CI pass again in I identified a PR that might be the reason of false positives in the |
youknowriad
pushed a commit
that referenced
this pull request
Jun 24, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jun 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addressed ESLInt rule violation for the missing import for
@wordpress/editorin@wordpress/block-library.@noisysocks removed
@wordpress/editoras a dependency from@wordpress/block-libraryin #32801. It was discovered as an issue by @youknowriad in #32848.We want to keep the hard rule about dependencies as proposed by @noisysocks so this PR copies the workaround used. A proper fix is going to be discussed in #32842.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).