Widgets editor: Display shortcuts for navigating regions#32757
Merged
Conversation
draganescu
approved these changes
Jun 17, 2021
Contributor
draganescu
left a comment
There was a problem hiding this comment.
Thanks for fixing 👍🏻 LGTM!
|
Size Change: +155 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
youknowriad
pushed a commit
that referenced
this pull request
Jun 21, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jun 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
5 minute fix for something I noticed in passing.
The shortcuts for navigating regions were missing from the standalone widgets screen keyboard shortcuts modal, so this fixes it.
Actually navigating regions still seemed to work. The styles could do with some improvement, but this also seems to be a problem in the post editor where the outline isn't visible at all (will raise as a separate issue as when I checked it wasn't a quick fix)
How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).