[Block Library - Query Loop]: Select first Query Loop found from pattern selection#32737
Merged
ntsekouras merged 2 commits intotrunkfrom Jun 25, 2021
Merged
Conversation
|
Size Change: -1.49 kB (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
Co-authored-by: Miguel Fonseca <miguelcsf@gmail.com>
Contributor
Author
|
@youknowriad should we back port this one? |
Contributor
|
we can consider it since it's a polish for a 5.8 feature and see. |
youknowriad
pushed a commit
that referenced
this pull request
Jun 29, 2021
…ern selection (#32737) * [Block Library - Query Loop]: Select first Query Loop found from pattern selection * Update packages/block-library/src/query/utils.js Co-authored-by: Miguel Fonseca <miguelcsf@gmail.com> Co-authored-by: Miguel Fonseca <miguelcsf@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves: #31252
After selecting a
Query Looppattern from the Placeholder during insertion, the selected block would be the last selected pattern's block. This doesn't need to be aQuery Loopblock necessarily.This PR searches for the first
Query Loopblock in the pattern's blocks and selects it, after we choose a pattern.Testing Instructions
Large titlepattern, which wraps theQuery Loopwith aGroupblock.Query Loopis selected.Of course you can check with other patterns as well like
Offsetor any custom pattern.