Block categories: Clean these up by moving several blocks from Design to Theme#32568
Merged
Block categories: Clean these up by moving several blocks from Design to Theme#32568
Conversation
Contributor
|
I wonder if "Theme" could be confused as meaning "provided by your theme." |
Contributor
My first thought was similar back when the category was created in #30016, but categories should not address a block's origin but their content; similarly, we don't have a "plugins" category. |
priethor
reviewed
Jun 10, 2021
Contributor
priethor
left a comment
There was a problem hiding this comment.
Looks good to me. In #30016 it was suggested to leave widget-like blocks (Site Logo, Title, etc) in the widgets section, so waiting for @mtias to confirm.
As a side note, if we do move these blocks to "Themes" we will have:
- Posts List block under "Themes"
- Latest Posts and Page List blocks under "Widgets".
Having these similarly named blocks in different categories can be confusing for users, but I don't think this should be a blocker as these widget blocks might be replaced in the future by more Query block variations (#32332).
priethor
approved these changes
Jun 16, 2021
53ea52c to
758c1c6
Compare
Contributor
|
Got the tests passing on this one! Feel free to press the green button 👌 |
youknowriad
pushed a commit
that referenced
this pull request
Jun 21, 2021
… to Theme (#32568) * navigation: update category from Design to Theme * loginout: update category from Design to Theme * query: update category from Design to Theme * post title: update category from Design to Theme * post content: update category from Design to Theme * post date: update category from Design to Theme * post excerpt: update category from Design to Theme * post featured image: update category from Design to Theme * post author: update category from Design to Theme * post comment: update category from Design to Theme * post comments: update category from Design to Theme * post comments count: update category from Design to Theme * post comments form: update category from Design to Theme * post comments link: update category from Design to Theme * term description: update category from Design to Theme * nextpage: update category from Design to Theme * break: undo category change * post navigation link: update category from Design to Theme
youknowriad
pushed a commit
that referenced
this pull request
Jun 21, 2021
… to Theme (#32568) * navigation: update category from Design to Theme * loginout: update category from Design to Theme * query: update category from Design to Theme * post title: update category from Design to Theme * post content: update category from Design to Theme * post date: update category from Design to Theme * post excerpt: update category from Design to Theme * post featured image: update category from Design to Theme * post author: update category from Design to Theme * post comment: update category from Design to Theme * post comments: update category from Design to Theme * post comments count: update category from Design to Theme * post comments form: update category from Design to Theme * post comments link: update category from Design to Theme * term description: update category from Design to Theme * nextpage: update category from Design to Theme * break: undo category change * post navigation link: update category from Design to Theme
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaning up the block categories within the Block Inserter. This PR moves the following blocks from the Design category to the Theme category, based on the intended usage of the blocks.