Block Library: Normalize theme block toolbars#31952
Merged
youknowriad merged 9 commits intotrunkfrom May 19, 2021
Merged
Conversation
priethor
commented
May 18, 2021
priethor
commented
May 18, 2021
Contributor
Author
|
I left the Query Block's |
|
Size Change: -21 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
May 19, 2021
Contributor
ntsekouras
left a comment
There was a problem hiding this comment.
Thanks for working on this @priethor!
I've left a couple of comments and Query needs to be updated in another file. Other than that I've tested all other blocks and are as expected.
youknowriad
reviewed
May 19, 2021
youknowriad
reviewed
May 19, 2021
youknowriad
reviewed
May 19, 2021
Contributor
youknowriad
left a comment
There was a problem hiding this comment.
This is looking good to me, just left some small messages for potential final touches.
e1865fd to
ae237aa
Compare
ntsekouras
approved these changes
May 19, 2021
Contributor
ntsekouras
left a comment
There was a problem hiding this comment.
This looks good! Thanks!
e2f38c6 to
ba6dc74
Compare
Normalize toolbars for blocks: Latest Posts, Post Author, Post Comments, Post Comments Count, Post Comments Form, Post Comments Link, Post Date, Post Title, Query, Query Title, Site Tagline, Social Links, Table, and Term Description.
Remove ToolbarGroup from Social Links Block toolbar as it's already provided by BlockControlSlot.
Normalize toolbars for blocks: Latest Posts, Post Author, Post Comments, Post Comments Count, Post Comments Form, Post Comments Link, Post Date, Post Title, Query, Query Title, Site Tagline, Social Links, Table, and Term Description.
ba6dc74 to
4325e93
Compare
jffng
pushed a commit
that referenced
this pull request
May 19, 2021
Co-authored-by: ntsekouras <ntsekouras@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #25983 similar to #29205, #29247, #29863, and #30012
Description
Normalize the toolbar for the remaining theme blocks and the table block:
Latest PostsQueryHow has this been tested?
Tested all blocks manually, visual comparisons before and after.
Screenshots
Types of changes
Adds the block
groupattribute toBlockControls, replacesAlignmentToolbarwithAlignmentControlwhere appropriate.Checklist:
*.native.jsfiles for terms that need renaming or removal).