Conversation
|
Size Change: -12 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
May 17, 2021
Contributor
ntsekouras
left a comment
There was a problem hiding this comment.
Tested and fixes the issue. Thanks!
Should we update the comment that refers to block appender though? Is it still valid?
Member
Author
|
Yes, good point. I'll need to check why this was changed in the first place. |
546d7e3 to
d09b75d
Compare
d09b75d to
0db868d
Compare
Merged
7 tasks
youknowriad
reviewed
Jun 4, 2021
| 'data-title': blockTitle, | ||
| className: classnames( | ||
| // The wp-block className is important for editor styles. | ||
| 'wp-block block-editor-block-list__block', |
Contributor
There was a problem hiding this comment.
wp-block shouldn't be added to blocks with the align wrapper, this broken full/wide alignments.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Regression from #30995.
Solution: the
wp-blockclass name should be applied to all block wrappers, even if there's alignment. An alignment wrapper is a bit like a pseudo-group blocks. It doesn't mean we need to remove thewp-blockclass from the aligned block.How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).