Block editor: async mode: enable only for blocks out of view#30995
Merged
Block editor: async mode: enable only for blocks out of view#30995
Conversation
ellatrix
commented
Apr 20, 2021
| multiSelectedBlockClientIds, | ||
| hasMultiSelection, | ||
| } = useSelect( selector, [ rootClientId ] ); | ||
| const intersectingBlocks = useContext( IntersectingBlocks ); |
Member
Author
There was a problem hiding this comment.
This will be a set of a small number of client IDs that are in view.
ellatrix
commented
Apr 20, 2021
| // This prop is explicitely computed and passed down | ||
| // to avoid being impacted by the async mode | ||
| // otherwise there might be a small delay to trigger the animation. | ||
| index={ index } |
Member
Author
There was a problem hiding this comment.
I wonder if we still need this when all blocks in view are updated synchronously.
ellatrix
commented
Apr 20, 2021
|
Size Change: +207 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
ellatrix
commented
Apr 20, 2021
| key={ clientId } | ||
| value={ | ||
| ! intersectingBlocks.has( clientId ) && | ||
| ! selectedBlocks.has( clientId ) |
Member
Author
There was a problem hiding this comment.
Leaving a check for selected blocks because I see some e2e test failures that I think come from a selected block being edited that is out of view.
youknowriad
reviewed
Apr 21, 2021
Contributor
youknowriad
left a comment
There was a problem hiding this comment.
this looks promising.
This was referenced Apr 21, 2021
youknowriad
reviewed
Apr 22, 2021
2aeef3e to
386a7d6
Compare
youknowriad
approved these changes
Apr 23, 2021
Contributor
youknowriad
left a comment
There was a problem hiding this comment.
There are some failing tests that are worth checking. But this looks good to me.
Member
Author
|
Yeah there's a failing test that I can't figure out atm. I'll need to have a fresh look next week I think. |
386a7d6 to
c3947bd
Compare
Member
Author
|
I think this is solid. Let's try it. |
This was referenced May 14, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #30249.
Fixes #30299.
Right now we prioritise select calls for selected blocks. This PR explores prioritising (disabling async mode) select calls for all blocks that are visible on the screen.
I'd expect there to be a small performance hit for typing, but the absolute increase should be the same for both small and large posts.
I tested a large post and I didn't really notice a difference. Perhaps the first character typed felt a bit slower (when typing mode get enabled and toolbars disappear), but I'm not sure without more testing. There's a delay for the first character in
trunkas well.How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).