Block editor: log error if styles are loaded through the compatibility layer#31870
Merged
youknowriad merged 4 commits intotrunkfrom May 19, 2021
Merged
Block editor: log error if styles are loaded through the compatibility layer#31870youknowriad merged 4 commits intotrunkfrom
youknowriad merged 4 commits intotrunkfrom
Conversation
f393436 to
705d486
Compare
|
Size Change: -750 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
705d486 to
cf16dee
Compare
989bd4d to
9ed2e9f
Compare
youknowriad
reviewed
May 19, 2021
| if ( isMatch && ! doc.getElementById( ownerNode.id ) ) { | ||
| // eslint-disable-next-line no-console | ||
| console.error( | ||
| `Stylesheet ${ ownerNode.id } should be added as an editor style.`, |
Contributor
There was a problem hiding this comment.
Block styles can also end up here as well right? Should we include that in the message? If it's a theme style sheet, make it an editor style, if it's a block style, assign it to the block style property?
Member
Author
There was a problem hiding this comment.
No, theme styles are handled through the settings, so they're always correctly loaded.
Contributor
There was a problem hiding this comment.
I was talking more about the styles that get these console errors printed. The message says that it should be added to "editor style" but "editor style" is only for "theme" editor styles right? Blocks and plugins shouldn't be using that right?
Member
Author
There was a problem hiding this comment.
Oh, right. For blocks it should be package.json. I'll link to the relevant documentation.
Member
Author
There was a problem hiding this comment.
I added more information now.
youknowriad
reviewed
May 19, 2021
youknowriad
approved these changes
May 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We must communicate that this is not the right way to load styles into the iframe. The compatibility layer could be removed in the future. Styles must be loaded properly as editor styles.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).