Re-enable passing post_id query arg for Server Side Rendering (#31786)#31787
Merged
Mamaduka merged 1 commit intoWordPress:trunkfrom May 19, 2021
Merged
Re-enable passing post_id query arg for Server Side Rendering (#31786)#31787Mamaduka merged 1 commit intoWordPress:trunkfrom
Mamaduka merged 1 commit intoWordPress:trunkfrom
Conversation
Contributor
Author
|
Here's the screen capture of the Site editor. I changed the Depth parameter. The Request URL doesn't contain the
|
Mamaduka
approved these changes
May 14, 2021
Member
Mamaduka
left a comment
There was a problem hiding this comment.
Looks good to me ✅
Thanks for fixing this @bobbingwide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A change in PR #29246 altered a test so that it always failed.
It was testing
typeof currentPostId.idwhich wasundefined; in the block editor currentPostId is an integer.Blocks which were Server Side Rendered and relied on the
post_idbeing passed in the REST request were failing to return anything. They still worked when rendered for the front end.I deleted three characters:
.id.How has this been tested?
Screenshots
Types of changes
Fixes a regression introduced in Gutenberg 10.4.0 by PR #29246
Checklist:
*.native.jsfiles for terms that need renaming or removal).