components: Fix Shortcut polymorphism#31555
Merged
sarayourfriend merged 6 commits intotrunkfrom May 21, 2021
Merged
Conversation
|
Size Change: +28 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
7eaf372 to
ed71ecc
Compare
bd8a8ed to
b88da38
Compare
b88da38 to
0f64aa5
Compare
ciampo
reviewed
May 20, 2021
ciampo
reviewed
May 20, 2021
ciampo
approved these changes
May 20, 2021
Contributor
ciampo
left a comment
There was a problem hiding this comment.
Rebased and left a couple of comments. but otherwise changes LGTM.
Also noting a failing e2e test, although it doesn't seem related to changes in this PR
0f64aa5 to
fe61224
Compare
fe61224 to
13ade4a
Compare
fullofcaffeine
added a commit
that referenced
this pull request
May 22, 2021
…-take-2 * trunk: (57 commits) Image block: fix cover transform and excessive re-rendering (#32102) compose: Add types to useMergeRefs (#31939) Navigation: Fix collapsing regression. (#32081) components: Promote Elevation (#31614) compose: Add types to useReducedMotion and useMediaQuery (#31941) Update the graphic that appears in the Template Editor welcome guide (#32055) Block Navigation: use CSS for indentation with known max indent instead of spacer divs (#32063) Fix broken template part converter modal styles. (#32097) compose: Add types to `usePrevious` (#31944) components: Add ZStack (#31613) components: Fix Shortcut polymorphism (#31555) compose: Add types to `useFocusReturn` (#31949) compose: Add types to `useDebounce` (#32015) List View: Simplify the BlockNavigation component (#31290) Remove query context leftovers (#32093) Remove filter_var from blocks (#32046) Templates: Remove now-obsolete gutenberg_get_template_paths() (#32066) [RNMobile] Enable reusable block only in WP.com sites (#31744) Rename ViewOwnProps to PolymorphicComponentProps (#32053) Rich text: remove inline display warning (#32013) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Shortcut previously did not support the
asprop that allViewOwnPropscomponents support. This fixes that. To do so we have to castViewto aPolymorphicComponentbecauseEmotion'sasprop doesn't work correctly with the types (it doesn't give you the correct types for the component when you passas)How has this been tested?
Unit tests continue to pass and usages of Shortcut can now correctly use the
asprop.Types of changes
Bug fix.
Checklist:
*.native.jsfiles for terms that need renaming or removal).