Merged
Conversation
|
Size Change: -117 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
Contributor
Author
|
There's more work to be done:
Some of those are in use and have new versions to replace them, others don't. Some aren't used at all. Some should be rethought. But this should be a decent start. |
youknowriad
approved these changes
May 19, 2021
Contributor
youknowriad
left a comment
There was a problem hiding this comment.
Maybe worth mentioning the removals (breaking change) in the CHANGELOG of the package. Other than that, this is good.
Contributor
Author
|
Thank you for the green check! I tried updating the changelog. Can you take a look and see if I did it right? |
Contributor
|
changelog change looks good to me. |
ocean90
reviewed
May 19, 2021
packages/icons/CHANGELOG.md
Outdated
|
|
||
| - Drop support for Internet Explorer 11 ([#31110](https://github.com/WordPress/gutenberg/pull/31110)). Learn more at https://make.wordpress.org/core/2021/04/22/ie-11-support-phase-out-plan/. | ||
| - Increase the minimum Node.js version to v12 matching Long Term Support releases ([#31270](https://github.com/WordPress/gutenberg/pull/31270)). Learn more at https://nodejs.org/en/about/releases/. | ||
| - Removed icons: `camera`, `chartLine`, `closeCircleFilled`, `controlsRepeat`, `expand`, as they all have better existing alternatives, and were unused by the block editor. |
Member
There was a problem hiding this comment.
Looks like the PR needs a rebase because 3.0.0 was released in the meantime, see https://github.com/WordPress/gutenberg/blob/trunk/packages/icons/CHANGELOG.md#300-2021-05-14.
Contributor
Author
There was a problem hiding this comment.
Welp. On it, thanks.
Member
There was a problem hiding this comment.
I think it would be nice to also document the "better existing alternatives" so a developer can easily swap them out. The entry for 2.0.0 has a good example.
Contributor
Author
There was a problem hiding this comment.
Let me know if I this looks good: a3316bc
Contributor
Author
There was a problem hiding this comment.
Cool let me see if I can do that.
Contributor
Author
There was a problem hiding this comment.
Took a stab at alternative suggestions in 22b3d64.
Contributor
Author
|
Thanks for the help, folks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A slew of icons were still using the old vectors, not the new ones from Figma. This PR updates a bunch, and retires a few.
Retired because they were unused:
Retired and swapped out:
Swapped this one with "fullscreen".
Updated:
To test:
Compare the icons in https://wordpress.github.io/gutenberg/?path=/story/icons-icon--library with the icons you get from checking out this branch and running
npm run storybook:dev. You can see the new icons at http://localhost:50240/?path=/story/icons-icon--library.Here are some:
I don't love the "cloud upload" icon, but one such is already shipping so I was hoping to find a design to keep the same shape but update it to the newer style.
Checklist:
*.native.jsfiles for terms that need renaming or removal).