Skip to content

Plugin: Fix "Undefined variable: $image_default_size"#31324

Merged
gziolo merged 1 commit intoWordPress:trunkfrom
them-es:patch-2
Apr 29, 2021
Merged

Plugin: Fix "Undefined variable: $image_default_size"#31324
gziolo merged 1 commit intoWordPress:trunkfrom
them-es:patch-2

Conversation

@them-es
Copy link
Copy Markdown
Contributor

@them-es them-es commented Apr 29, 2021

Description

Renamed wrong PHP variable

How has this been tested?

Manual testing in PHP debug mode

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@Mamaduka Mamaduka added the [Type] Bug An existing feature does not function as intended label Apr 29, 2021
@Mamaduka
Copy link
Copy Markdown
Member

Hi, @them-es

Thanks for catching this, and the change looks good 👍

@gziolo, I also see this typo in core: WordPress/wordpress-develop@a19f589#diff-edfc853e670c7bfc5a838dc74f75ba5d8b95cb4adbddf0644d9227bcb692e344R174

Copy link
Copy Markdown
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I will fix in WordPress Core 👍🏻

@gziolo gziolo changed the title Fix "Undefined variable: $image_default_size" Plugin: Fix "Undefined variable: $image_default_size" Apr 29, 2021
@gziolo gziolo added the Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts label Apr 29, 2021
@gziolo gziolo merged commit 5f9fd02 into WordPress:trunk Apr 29, 2021
@github-actions github-actions bot added this to the Gutenberg 10.6 milestone Apr 29, 2021
@gziolo gziolo modified the milestones: Gutenberg 10.6, Gutenberg 10.5 Apr 29, 2021
nylen pushed a commit to nylen/wordpress-develop-svn that referenced this pull request Apr 29, 2021
Related change in Gutneberg: WordPress/gutenberg#31324

Props mamaduka.
See #52920.



git-svn-id: https://develop.svn.wordpress.org/trunk@50798 602fd350-edb4-49c9-b593-d223f7449a82
pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Apr 29, 2021
Related change in Gutneberg: WordPress/gutenberg#31324

Props mamaduka.
See #52920.



git-svn-id: https://develop.svn.wordpress.org/trunk@50798 602fd350-edb4-49c9-b593-d223f7449a82
@gziolo
Copy link
Copy Markdown
Member

gziolo commented Apr 29, 2021

Backported to WordPress core: WordPress/wordpress-develop@f826a6a.

markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Apr 29, 2021
Related change in Gutneberg: WordPress/gutenberg#31324

Props mamaduka.
See #52920.


Built from https://develop.svn.wordpress.org/trunk@50798


git-svn-id: http://core.svn.wordpress.org/trunk@50407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott pushed a commit to gMagicScott/core.wordpress-mirror that referenced this pull request Apr 29, 2021
Related change in Gutneberg: WordPress/gutenberg#31324

Props mamaduka.
See #52920.


Built from https://develop.svn.wordpress.org/trunk@50798


git-svn-id: https://core.svn.wordpress.org/trunk@50407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
F-Wilke pushed a commit to FiliagoDev/WordPress that referenced this pull request Jul 31, 2021
Related change in Gutneberg: WordPress/gutenberg#31324

Props mamaduka.
See #52920.


Built from https://develop.svn.wordpress.org/trunk@50798


git-svn-id: http://core.svn.wordpress.org/trunk@50407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants