Components: Query autocomplete by the term from last trigger prefix character#30540
Merged
Conversation
|
Size Change: +6 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
fullofcaffeine
approved these changes
Apr 6, 2021
fullofcaffeine
left a comment
Member
There was a problem hiding this comment.
This tests well! And the multi-word searching still works as expected.
noahtallen
approved these changes
Apr 6, 2021
noahtallen
left a comment
Member
There was a problem hiding this comment.
I verified that multiword search works (e.g. @Noah Allen or /Instagram Posts) as does multiple searches per block (@noahtallen @WunderBart)
Member
|
We have
|
gziolo
reviewed
Apr 7, 2021
| new RegExp( `${ safeTrigger }([\u0000-\uFFFF]*)$` ) | ||
| ); | ||
| const match = text | ||
| .slice( text.lastIndexOf( completer.triggerPrefix ) ) |
Member
There was a problem hiding this comment.
Good catch, it makes a lot of sense.
It feels like we could update the RegExp to match the last occurrence (rather than using slice), but I'm afraid it would be harder to follow for those who need to google it like me:
https://frightanic.com/software-development/regex-match-last-occurrence/
gziolo
approved these changes
Apr 7, 2021
gziolo
left a comment
Member
There was a problem hiding this comment.
Nice one, thank you for fixing it. Do you consider it as a candidate for the hotfix release? We can coordinate on WordPress Slack in the #core-editor channel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue introduced in #29939, where the search won't retrigger when more than one inline trigger prefix is present.
How has this been tested?
The autocomplete search results should appear every time the search trigger is typed, i.e. the user search via⚠️ The above does not apply to the block search because of its custom allowContext condition.)
@.(
Confirm that searching blocks via multiple words is still working as described in #29939.
Types of changes
Bugfix