Size Change: +13 B (0%)

Total Size: 1.41 MB

_{compressed-size-action}

I caused it so I will follow this closely 😬

This seems an interim fix and not the fix for the root problem, so I don't think we should land this.

There may be a larger root to address, but I also think it makes sense to not assume we have retrieved a proper post object in every possible circumstance. If we are going to show placeholder titles, we should do that when no proper post context is found as well.

Whats happening here is postType and postId come into the component as undefined for this post title block when the query placeholder is inserted somewhere that is not inside the context of a post (the root of the Index template for example). This results in the getEditedEntityRecord returning an empty object {}, thus title and link are undefined.

There is not a problem once we are in the context of a post (placing this inside a page, post, or other query block), as it will pick up that context and show that title in the preview. Since the query block is our means of supplying a post context to these blocks, I think its fair to assume in placeholder flow/setup that no context may exist.

In my quick check I think it has to do with isLink handling in Post Title,

Sort of, its only triggered when isLink is true. But it happens because of the lack of context supplies the undefined title.

So it may be worthwhile to change the condition for the isLink version of the component from if ( isLink ) to if ( isLink && link ) (?), but I think defaulting the title to fallback to an empty string is still a warranted safety measure since we treat it as a string in all circumstances.