Block Library: Fix Query block undo trap during creation#30203
Merged
Conversation
ntsekouras
commented
Mar 24, 2021
| updateQuery( newQuery ); | ||
| } | ||
| }, [ query.perPage, query.inherit ] ); | ||
| }, [ query.perPage ] ); |
Contributor
Author
There was a problem hiding this comment.
This is unrelated and just a leftover..
|
Size Change: +28 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
Addison-Stavlo
approved these changes
Mar 24, 2021
Addison-Stavlo
left a comment
Contributor
There was a problem hiding this comment.
Tested, and this fixes the undo trap as expected! Undo/redo and save flows seem to work as expected.
Unrelated to the change here, I noticed some errors in the console related to the post title block:
and opened a quick fix PR #30208
Contributor
|
🤔 Noticing a small thing, although cannot consistently reproduce: If i insert query block -> select a pattern -> save the changes -> select 'undo': it seems "redo" is sometimes not an available option. It seems small and overall this feels like a big step up from where it was, but noticing that inconsistency at times. |
Member
|
Oh, do you think this could work for the image block too? #30114 |
annezazu
reviewed
Mar 24, 2021
annezazu
left a comment
Contributor
There was a problem hiding this comment.
Can't comment on the code but the experience worked great based on my testing! Thanks for getting this in place - it's come up a few times with the FSE outreach program:
query.mov
The only thing I noticed is that the site content was all out of wack in terms of width but I'm guessing that's due to the recent PR exploring changing how alignments are handled with FSE & block themes.
carolinan
approved these changes
Mar 25, 2021
carolinan
left a comment
Contributor
There was a problem hiding this comment.
I was able to replicate the problem, and in my tests this PR solves the issue.
I am seeing the same JS error mentioned above, but the redo is working well for me.
Contributor
Author
|
I noticed this error yesterday and meant to see the root cause of this tomorrow. In my quick check I think it has to do with
I guess so, it seems like a similar problem. I'll check the PR better tomorrow though and it's worth trying I think @ellatrix . |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #29494
In
Queryblock there are some effects running where some initialization logic is happening and setting some values to some attributes (ex. queryId).These updates can cause an
undo trapwhere undoing will result in resetting again, so we need to mark these changes as not persistent with__unstableMarkNextChangeAsNotPersistent.Testing instructions
undois performed properly and everything else works as before and expected.Screenshots