fix: Undefined index "colors" warning#2982
Merged
gziolo merged 2 commits intoWordPress:masterfrom Oct 11, 2017
ayoolatj:fix/2198-undefined-index-colors
Merged
fix: Undefined index "colors" warning#2982gziolo merged 2 commits intoWordPress:masterfrom ayoolatj:fix/2198-undefined-index-colors
gziolo merged 2 commits intoWordPress:masterfrom
ayoolatj:fix/2198-undefined-index-colors
Conversation
gziolo
requested changes
Oct 11, 2017
Member
gziolo
left a comment
There was a problem hiding this comment.
Thanks for opening this PR. It fixes the bug described in #2198:
<b>Notice</b>: Undefined index: colors in <b>/srv/www/editor/htdocs/wp-content/plugins/gutenberg/lib/client-assets.php</b> on line <b>654</b><br />but there is still another PHP notice in this code that needs to be fixed:
<b>Notice</b>: Undefined index: wide-images in <b>/srv/www/wordpress-default/public_html/wp-content/plugins/lib/client-assets.php</b> on line <b>791</b><br>
Contributor
Author
|
I've updated my code to fix the second php notice |
gziolo
reviewed
Oct 11, 2017
lib/client-assets.php
Outdated
Member
There was a problem hiding this comment.
I'm wondering if empty isn't powerful enough to make it possible to simplify it to:
if ( ! empty( $gutenberg_theme_support[0]['colors'] ) ) {
Contributor
Author
There was a problem hiding this comment.
Sorry, I'm a little lost. Can you explain further?
Member
There was a problem hiding this comment.
Determine whether a variable is considered to be empty. A variable is considered empty if it does not exist or if its value equals FALSE. empty() does not generate a warning if the variable does not exist.
You don't need to check if $gutenberg_theme_support is truthy, because empty does that, too. It makes this line shorter and works exactly the same.
Member
There was a problem hiding this comment.
I just tested with the following code:
function mytheme_setup_theme_supported_features() {
add_theme_support( 'gutenberg', null );
}
add_action( 'after_setup_theme', 'mytheme_setup_theme_supported_features' );
Contributor
Author
There was a problem hiding this comment.
Yeah that's right, should I update the PR with this?
Member
There was a problem hiding this comment.
If you like it, then go for it. Totally up to you :)
Member
|
That was quick, thanks. Testing your changes :) |
gziolo
reviewed
Oct 11, 2017
lib/client-assets.php
Outdated
Member
There was a problem hiding this comment.
In this place it would get simplified to the following:
'wideImages' => ! empty( $gutenberg_theme_support[0]['wide-images'] ) ),
Member
|
Thanks for another update. It looks great now. 🎉 |
DevinWalker
added a commit
to DevinWalker/gutenberg
that referenced
this pull request
Oct 12, 2017
* master: (45 commits) Parser: Hide the core namespace in serialised data (WordPress#2950) fix: Undefined index warning (WordPress#2982) navigation via keydown PHPCS improvements (WordPress#2914) Update/html block description (WordPress#2917) Framework: Merge EditorSettingsProvider into EditorProvider Framework: Move the store initialization to a dedicated component Rotate header ellipsis to match block ellipsis add/459: Added support for ins, sub and sup Refresh nonce with heartbeat (WordPress#2790) Paste: add table support Bump version to 1.4.0. (WordPress#2954) Blocks: The custom classname should be persisted properly in the block's comment Editor: Fix the scroll position when reordering blocks Polish spacing in block ellipsis menu (WordPress#2955) Editor: HTML Editor per block (WordPress#2797) Show most frequently used blocks next to inserter (WordPress#2877) add/459: Added light grey background to selected inline boundaries Extend inline boundaries to other elements Move markdown fix to own plugin-compatibility file ...
DevinWalker
added a commit
to DevinWalker/gutenberg
that referenced
this pull request
Oct 12, 2017
* master: (45 commits) Parser: Hide the core namespace in serialised data (WordPress#2950) fix: Undefined index warning (WordPress#2982) navigation via keydown PHPCS improvements (WordPress#2914) Update/html block description (WordPress#2917) Framework: Merge EditorSettingsProvider into EditorProvider Framework: Move the store initialization to a dedicated component Rotate header ellipsis to match block ellipsis add/459: Added support for ins, sub and sup Refresh nonce with heartbeat (WordPress#2790) Paste: add table support Bump version to 1.4.0. (WordPress#2954) Blocks: The custom classname should be persisted properly in the block's comment Editor: Fix the scroll position when reordering blocks Polish spacing in block ellipsis menu (WordPress#2955) Editor: HTML Editor per block (WordPress#2797) Show most frequently used blocks next to inserter (WordPress#2877) add/459: Added light grey background to selected inline boundaries Extend inline boundaries to other elements Move markdown fix to own plugin-compatibility file ...
DevinWalker
added a commit
to DevinWalker/gutenberg
that referenced
this pull request
Oct 12, 2017
* master: (45 commits) Parser: Hide the core namespace in serialised data (WordPress#2950) fix: Undefined index warning (WordPress#2982) navigation via keydown PHPCS improvements (WordPress#2914) Update/html block description (WordPress#2917) Framework: Merge EditorSettingsProvider into EditorProvider Framework: Move the store initialization to a dedicated component Rotate header ellipsis to match block ellipsis add/459: Added support for ins, sub and sup Refresh nonce with heartbeat (WordPress#2790) Paste: add table support Bump version to 1.4.0. (WordPress#2954) Blocks: The custom classname should be persisted properly in the block's comment Editor: Fix the scroll position when reordering blocks Polish spacing in block ellipsis menu (WordPress#2955) Editor: HTML Editor per block (WordPress#2797) Show most frequently used blocks next to inserter (WordPress#2877) add/459: Added light grey background to selected inline boundaries Extend inline boundaries to other elements Move markdown fix to own plugin-compatibility file ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check that key exists and is not empty.
resolves: #2198