Buttons: Add space-between justification controls#29160
Merged
Conversation
|
Size Change: +65 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
Contributor
|
Thanks for this! I'm not seeing it have any effect, though, on the horizontal one (and I agree it shouldn't be there for the vertical one):
Buttons had "fake" space between recently, because the horizontal margins were set to auto (see also #28878) — but in inspecting, I don't see any justification CSS being output. It works when I add
|
Contributor
|
Also, good to be aware of: #29165 |
jasmussen
approved these changes
Feb 22, 2021
Contributor
jasmussen
left a comment
There was a problem hiding this comment.
I don't know why it didn't work before, but it works now. Nice:
mkevins
added a commit
that referenced
this pull request
Apr 8, 2021
Note: this is a partial revert of #29160, but this can be re-enabled after testing, when support for this is added on mobile.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #28768 the justificatoon toolbar was added, however the space-between option was purposely left out to match previous functionality. Well, turns out there was no real reason and buttons get space-between too.
How has this been tested?
Screenshots
Types of changes
Open Question
@jasmussen what should we do about
is-vertical? This might be why it was left off previously.After recording the screenshot, it seems rather obvious that it doesn't quite make sense for vertical, so I pushed up a change to remove the option if vertical orientation. So if/when you test that will be different than screenshot.