Revert date changes from branch 'replace-moment'#27550
Merged
Conversation
added 2 commits
December 7, 2020 10:57
31 tasks
|
Size Change: +20.6 kB (1%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
Member
|
Unit tests are passing locally ✅ Let's see what happens to the E2E tests. |
Contributor
|
For context: We've decided to revert after discussion between @vcanales, @david-szabo97, and myself, since the While we have two fixes in the works (#27398 and #27519), it's hard to ensure that they cover all issues and don't introduce new bugs, since we're also lacking test coverage (#27500). Our plan is thus:
|
6 tasks
6 tasks
david-szabo97
approved these changes
Dec 7, 2020
Member
david-szabo97
left a comment
There was a problem hiding this comment.
Tested in UTC-10 and UTC+10, LGTM ✅
31 tasks
ellatrix
pushed a commit
that referenced
this pull request
Dec 7, 2020
* Revert "Fix c and r formats, add tests." This reverts commit 1f73702. * Revert date changes from branch 'replace-moment' * fix merge error
This was referenced Dec 7, 2020
WunderBart
pushed a commit
that referenced
this pull request
Dec 8, 2020
* Revert "Fix c and r formats, add tests." This reverts commit 1f73702. * Revert date changes from branch 'replace-moment' * fix merge error
Merged
This was referenced Jan 12, 2021
Member
|
@vcanales Did you ever get around to taking another stab at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert changes from #25782 and #27002. The move made on #25782 was prematurely deemed correct, and a lot of timezone issues were surfaced later. The plan going forward is to improve on testing, including testing on multiple timezones.
This will deal with a collection of issues, which should be taken into account when this is revisited:
Checklist: