Conversation
|
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
bobbingwide
reviewed
Nov 26, 2020
Contributor
bobbingwide
left a comment
There was a problem hiding this comment.
I tested this fix with the following templates: archive-block, archive-oik-plugins, page-$id, page-$slug.
youknowriad
approved these changes
Nov 26, 2020
Contributor
|
This seems to have been merged with failing tests, and they're failing consistently in Would be great to fix these. |
Member
Author
|
I don't think it's related to this PR... The same tests were also failing before this got merged (for example on https://github.com/WordPress/gutenberg/runs/1459198647) and I don't see how this change could have affected anything else 🤔 |
Contributor
|
@aristath 😕 That's a completely different test to the one I mentioned. |
Member
Author
|
ooooh you're right, my bad. |
Contributor
|
Awesome, thanks! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27177
Description
As per the discussion on #27177, this PR fixes the issue by simplifying the
usortcallback.How has this been tested?
Tested by creating a custom post-type and verifying that the
archive-$post_typetemplate loads beforearchive.Checklist:
cc @bobbingwide