[RNMobile] Do not propagate parent's variation to variation#25400
Merged
lukewalczak merged 1 commit intomasterfrom Sep 17, 2020
Merged
[RNMobile] Do not propagate parent's variation to variation#25400lukewalczak merged 1 commit intomasterfrom
lukewalczak merged 1 commit intomasterfrom
Conversation
|
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
geriux
approved these changes
Sep 17, 2020
Member
geriux
left a comment
There was a problem hiding this comment.
LGTM! Thanks for handling this bug! Tested it on both iOS and Android.
2 tasks
ceyhun
pushed a commit
that referenced
this pull request
Sep 17, 2020
cameronvoell
pushed a commit
that referenced
this pull request
Sep 22, 2020
* Release script: Update react-native-editor version to 1.37.0 * Release script: Update with changes from 'npm run core preios' * [RNMobile] Correct colors when switching between modes (#25328) * [RNMobile] Do not propagate parent's variation to variation (#25400) * Update react-native-* package versions to 1.37.1 * Update with changes from 'npm run core preios' * [iOS] Open access to GutnebergWebVC API (#25449) Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com> Co-authored-by: etoledom <etoledom@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: wordpress-mobile/gutenberg-mobile#2634
Ref to gutenberg-mobile: wordpress-mobile/gutenberg-mobile#2636
Description
Set an empty array while creating a variation block, which should not propagate the parent's variation to itself.
How has this been tested?
Screenshots
Types of changes
Checklist: