Update Preview, Save and Switch to Draft button labels blue#24420
Merged
draganescu merged 1 commit intomasterfrom Aug 7, 2020
Merged
Update Preview, Save and Switch to Draft button labels blue#24420draganescu merged 1 commit intomasterfrom
draganescu merged 1 commit intomasterfrom
Conversation
…uttons are blue again.
Contributor
|
Thank you for the PR! This is a very basic PR that removes 7 lines of code. That makes it very safe, very predictable, and it improves things. It also does not preclude further explorations. 👍 👍 from me. |
Contributor
|
Ship it. |
|
Size Change: -34 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
ZebulanStanphill
approved these changes
Aug 6, 2020
Member
ZebulanStanphill
left a comment
There was a problem hiding this comment.
I'm the one who created #21192, which changed the "Save draft" button to look the way it does in master right now. Sorry for that, though to be fair, the "Preview" button was already using that style, albeit with a redundant chevron next to it.
I'm definitely approving this PR. It removes more special-case CSS, it makes the buttons more obvious, and it improves upon the consistency that I had wanted to achieve with my PR.
In the future I'd suggest trying to find a way to avoid coloring any buttons blue by default, simply because it feels weird to have the text buttons colored blue by default, but the icon buttons colored black. Maybe just add a black outline to the text buttons? But for now, this PR is a definite improvement over master.
whyisjake
pushed a commit
that referenced
this pull request
Aug 9, 2020
…uttons are blue again. (#24420)
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23890.
This PR aims to help resolve some issues around the Switch to Draft, Save, and Preview buttons in the editor's top toolbar, which were updated in #21192. In #23890 there are some concerns that these buttons now look like plain text. One suggestion brought up by the accessibility team was to switch the color to blue, and that's what this PR does.
Here's how they look in
mastertoday:And here's how they look in this PR: