[Mobile] Disable Page Template picker if Modal Layout Picker is enabled#24061
Merged
[Mobile] Disable Page Template picker if Modal Layout Picker is enabled#24061
Conversation
|
Size Change: +346 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
3 tasks
2 tasks
mchowning
reviewed
Jul 22, 2020
| const val PROP_CAPABILITIES = "capabilities" | ||
| const val PROP_CAPABILITIES_MENTIONS = "mentions" | ||
| const val PROP_CAPABILITIES_UNSUPPORTED_BLOCK_EDITOR = "unsupportedBlockEditor" | ||
| const val PROP_NAME_MODAL_LAYOUT_PICKER = "modalLayoutPicker" |
Contributor
There was a problem hiding this comment.
Not a big deal, but for the sake of consistency with the other "capabilities" props, what would you think about renaming this variable to "PROP_CAPABILITIES_MODAL_LAYOUT_PICKER"?
Member
Author
There was a problem hiding this comment.
You are right @mchowning . I copy pasted the wrong naming from the old code.
Thank you for your feedback :)
chipsnyder
approved these changes
Jul 22, 2020
Contributor
chipsnyder
left a comment
There was a problem hiding this comment.
LGTM! Thanks for making that naming change.
antonis
commented
Jul 23, 2020
| val isDarkMode: Boolean, | ||
| val htmlModeEnabled: Boolean | ||
| val htmlModeEnabled: Boolean, | ||
| val isModalLayoutPickerEnabled: Boolean |
Member
Author
There was a problem hiding this comment.
I was thinking of adding a default value to the new parameter in order to be able to merge this early without breaking the WP-Android code. Something like the following:
data class GutenbergProps @JvmOverloads constructor(
val enableMentions: Boolean,
val enableUnsupportedBlockEditor: Boolean,
val localeSlug: String,
val postType: String,
val editorTheme: Bundle?,
val translations: Bundle,
val isDarkMode: Boolean,
val htmlModeEnabled: Boolean
val htmlModeEnabled: Boolean,
val isModalLayoutPickerEnabled: Boolean = false
) {
Wdyt @mchowning , @chipsnyder ?
Contributor
There was a problem hiding this comment.
That seems like a good plan to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: wordpress-mobile/gutenberg-mobile#2419
Related PRs:
WordPress-Android: [Modal Layout Picker] Create Modal window for Modal Layout Picker wordpress-mobile/WordPress-Android#12482gutenberg-mobile: [Modal Layout Picker] Disable Page Template picker if MLP is enabled wordpress-mobile/gutenberg-mobile#2494Description
Adds a capability to hide the editor layout picker when the Modal Layout Picker(MLP) is enabled.
For detailed description of this PR please check wordpress-mobile/WordPress-Android#12482
Notes
This has been updated with the Consolidation of the Gutenberg initialProps handling
How has this been tested?
This feature can be tested by using the build from wordpress-mobile/WordPress-Android#12482
Screenshots
Types of changes
New feature
Checklist: