apply the reset mixin to the inserter panel#23744
Merged
Merged
Conversation
|
Size Change: +475 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
2ea5f7e to
0e7940e
Compare
Contributor
|
This fixes the issue in Twenty Nineteen:
But I'm still seeing it in 2017:
...and 2015:
Resetting the margin to |
Contributor
Author
|
Yes, this was raised I believe already. Having margins on the editor styles do break more than the patterns preview. |
Contributor
@youknowriad Is this something we can fix at least for pattern previews? |
Contributor
Author
|
As you can see on your screenshots, the "gray" area around the canvas is a symptom of that issue. This should be definitely fixed in the editor styles (track ticket), that said I forced the margins for the preview to fix it for the patterns. |
Contributor
Author
|
Merging this to include in the release. |
youknowriad
added a commit
that referenced
this pull request
Jul 8, 2020
youknowriad
added a commit
that referenced
this pull request
Jul 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #23720
Ideally the theme editor styles shouldn't depend on global resets like this but this makes it consistent in the editor regardless.
testing instructions