Skip to content

Add more space for german.#23738

Merged
jasmussen merged 1 commit into
masterfrom
fix/german
Jul 7, 2020
Merged

Add more space for german.#23738
jasmussen merged 1 commit into
masterfrom
fix/german

Conversation

@jasmussen

@jasmussen jasmussen commented Jul 7, 2020

Copy link
Copy Markdown
Contributor

Fixes #23724

I've increased the width to allow more space for the labels.
Screenshot 2020-07-07 at 09 41 10

@jasmussen jasmussen added the [Type] Bug An existing feature does not function as intended label Jul 7, 2020
@jasmussen jasmussen self-assigned this Jul 7, 2020
@jasmussen jasmussen requested a review from Soean July 7, 2020 07:42
@jasmussen jasmussen mentioned this pull request Jul 7, 2020
Closed
@github-actions

github-actions Bot commented Jul 7, 2020

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 1.13 MB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.68 kB 0 B
build/api-fetch/index.js 3.4 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 7.67 kB 0 B
build/block-directory/style-rtl.css 944 B 0 B
build/block-directory/style.css 945 B 0 B
build/block-editor/index.js 110 kB 0 B
build/block-editor/style-rtl.css 10.7 kB 0 B
build/block-editor/style.css 10.7 kB 0 B
build/block-library/editor-rtl.css 7.57 kB 0 B
build/block-library/editor.css 7.57 kB 0 B
build/block-library/index.js 130 kB 0 B
build/block-library/style-rtl.css 7.78 kB 0 B
build/block-library/style.css 7.79 kB 0 B
build/block-library/theme-rtl.css 728 B 0 B
build/block-library/theme.css 729 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.2 kB 0 B
build/components/index.js 199 kB 0 B
build/components/style-rtl.css 15.8 kB 0 B
build/components/style.css 15.8 kB 0 B
build/compose/index.js 9.56 kB 0 B
build/core-data/index.js 11.4 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.44 kB 0 B
build/date/index.js 5.38 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 3.23 kB 0 B
build/edit-navigation/index.js 9.93 kB 0 B
build/edit-navigation/style-rtl.css 1.02 kB 0 B
build/edit-navigation/style.css 1.02 kB 0 B
build/edit-post/index.js 304 kB 0 B
build/edit-post/style-rtl.css 5.57 kB 0 B
build/edit-post/style.css 5.57 kB 0 B
build/edit-site/index.js 16.6 kB 0 B
build/edit-site/style-rtl.css 3.03 kB 0 B
build/edit-site/style.css 3.03 kB 0 B
build/edit-widgets/index.js 9.35 kB 0 B
build/edit-widgets/style-rtl.css 2.45 kB 0 B
build/edit-widgets/style.css 2.45 kB 0 B
build/editor/editor-styles-rtl.css 537 B 0 B
build/editor/editor-styles.css 539 B 0 B
build/editor/index.js 45 kB 0 B
build/editor/style-rtl.css 3.78 kB 0 B
build/editor/style.css 3.78 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.73 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.12 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.32 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.41 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.41 kB 0 B
build/priority-queue/index.js 788 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 13.9 kB 0 B
build/server-side-render/index.js 2.71 kB 0 B
build/shortcode/index.js 1.69 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

Soean
Soean approved these changes Jul 7, 2020
View reviewed changes

@Soean Soean left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and fixes the bug.

@jasmussen

jasmussen commented Jul 7, 2020

Copy link
Copy Markdown
Contributor Author

Thank you. I'll merge when the checks pass.

@jasmussen jasmussen merged commit d817dc4 into master Jul 7, 2020
@jasmussen jasmussen deleted the fix/german branch July 7, 2020 09:04
@github-actions github-actions Bot added this to the Gutenberg 8.6 milestone Jul 7, 2020
@ellatrix

ellatrix commented Jul 13, 2020

Copy link
Copy Markdown
Member

Would this be a valid use case for a table?

youknowriad pushed a commit that referenced this pull request Jul 13, 2020
@jasmussen @youknowriad
Add more space for german. (#23738)
84f7682 
Co-authored-by: Joen A <>
@youknowriad youknowriad mentioned this pull request Jul 13, 2020
Merged
@jasmussen

jasmussen commented Aug 3, 2020

Copy link
Copy Markdown
Contributor Author

Would this be a valid use case for a table?

😱

Maybe? Is there a benefit to that though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Soean Soean Soean approved these changes

Assignees

@jasmussen jasmussen

Labels

[Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

Gutenberg 8.6

Development

Successfully merging this pull request may close these issues.

Sidebar controls: space after label is missing.

3 participants

@jasmussen @ellatrix @Soean