Inline font-sizes: avoid modifying the BlockListBlock props object#23717
Merged
Inline font-sizes: avoid modifying the BlockListBlock props object#23717
Conversation
|
Size Change: +8 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Jul 6, 2020
| }, | ||
| }; | ||
|
|
||
| return <BlockListBlock { ...newProps } />; |
Contributor
There was a problem hiding this comment.
I wonder if returning here will cause "remounting" of the component? Can we instead keep the mutation here but declarer newProps at the top of the component (and spread props)
Member
|
Thanks :) I think I was loading the wrong branch... |
gziolo
pushed a commit
that referenced
this pull request
Jul 7, 2020
…23717) - Avoid changing the `BlockListBlock` props object in the `withFontSizeInlineStyles` HOC. - Also fix a typo in the `useFontSizes` hook name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BlockListBlockprops object in thewithFontSizeInlineStylesHOC.useFontSizeshook name.How has this been tested?
Tested with
wp-envon both Firefox 78 and Chrome 83 on macOS 10.15.5.The issue appeared in the Site Editor while editing the
hometemplate of the theme Seedlet (Blocks).Screenshots
This screenshot was captured while testing the Site Editor.
Both
Sectionblocks were breaking because of anUncaught TypeError: can't define property "wrapperProps": Object is not extensible, thrown by this line:https://github.com/WordPress/gutenberg/pull/22668/files#diff-7e9533138d2d1bd1c8f0f4b32d2d3aa4R189
Types of changes
Bug fix
Checklist: