Fix radio control in Windows High Contrast mode.#23706
Merged
Merged
Conversation
|
Size Change: +23 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
tellthemachines
approved these changes
Jul 7, 2020
tellthemachines
left a comment
Contributor
There was a problem hiding this comment.
This works well! Thanks for fixing 🎉
youknowriad
pushed a commit
that referenced
this pull request
Jul 13, 2020
waclawjacek
pushed a commit
to Automattic/woocommerce-services
that referenced
this pull request
Jan 18, 2021
Due to an update in @wordpress/base-styles used by WooCommerce Admin, the dots in WCS&T's radio buttons were no longer centered: WordPress/gutenberg#23706 This is now fixed and support for high contrast mode in Windows is added in alignment with the aforementioned PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The radio control was broken in Windows high contrast mode. In this mode all box shadows and background colors are removed, only borders and outlines are not.
Before:
After:
In normal mode: