[RNMobile] Correct Buttons block width#23616
Merged
lukewalczak merged 1 commit intomasterfrom Jul 6, 2020
Merged
Conversation
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
dratwas
approved these changes
Jul 6, 2020
SergioEstevao
pushed a commit
that referenced
this pull request
Jul 6, 2020
5 tasks
SergioEstevao
added a commit
that referenced
this pull request
Jul 8, 2020
* Run pod install in react-native-editor/ios/ * [RN-MOBILE] fix line height crash (#23507) * Fix line-height crash * format fix * Add block example with lineHeight attribute * [RNMobile] Correct Buttons block width (#23616) * Fix quote left border color in dark mode. (#23692) * Update react-native-editor package and release notes. * Fix translations for media options * Load block-library lazily after translations occur to fix names of blocks in inserter. * lint fixes * Merge master branch to merge_rnmobile_1.31.1_to_master Co-authored-by: Paul Von Schrottky <paul.von.schrottky@automattic.com> Co-authored-by: Marko Savic <savicmarko1985@gmail.com> Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com> Co-authored-by: Sérgio Estêvão <sergioestevao@gmail.com> Co-authored-by: Cameron Voell <cameronvoell@gmail.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Looks like
stylecannot be destructured along with...otherPropsthat's why I had to separate them.However, I would like to ask @dratwas to check what happens on the native side ✌️
How has this been tested?
Screenshots
Types of changes
Checklist: