Add Notice view for Copy/Cut blocks#23113
Merged
geriux merged 19 commits intornmobile/copy-duplicate-blocksfrom Jun 12, 2020
Merged
Add Notice view for Copy/Cut blocks#23113geriux merged 19 commits intornmobile/copy-duplicate-blocksfrom
geriux merged 19 commits intornmobile/copy-duplicate-blocksfrom
Conversation
…icate-blocks-plus-notices
…com:WordPress/gutenberg into rnmobile/copy-duplicate-blocks-plus-notices
…icate-blocks-plus-notices # Conflicts: # packages/block-editor/src/components/block-mobile-toolbar/block-actions-menu.native.js
2 tasks
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
pinarol
commented
Jun 12, 2020
16 tasks
geriux
reviewed
Jun 12, 2020
Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com>
Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com>
geriux
reviewed
Jun 12, 2020
Member
|
This is looking good! 👏 Nice work 🎉 just left a couple of messages and some are optional =D |
geriux
approved these changes
Jun 12, 2020
Member
geriux
left a comment
There was a problem hiding this comment.
Thank you for the changes! LGTM! Nice work 🙌
geriux
pushed a commit
that referenced
this pull request
Jun 30, 2020
* RNMobile - Copy / Duplicate functionality and Menu Inserter refactor: Move items rendering to its own component * RNMobile - Store selector fix after merge * RNMobile - Cut feature * RNMobile - Verify if block can be inserted from clipboard * RNMobile - Cut functionality * RNMobile - Remove unused async * Add Notice view for Copy/Cut blocks (#23113) * Add notices * Remove duplicate function * Fix errors * Update NoticeList * Fix default val * Bind on notice hidden * Add timer and fix formatting * Prevent NoticeList from appearing inside nested blocks * Update animation * RNMobile - Notice - Fix animation * Add onDimensionsChange listener * RNMobile - FloatingToolbar - Disable pointer Events if its not visible * Make zIndex values get effective * Update packages/components/src/notice/index.native.js Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com> * Update packages/components/src/notice/list.native.js Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com> * Simplify reducer Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com> * RNMobile - Fix lint error and change the default value of the Notice component animation * Mobile - Notice component - Blur effect for iOS and change styling for Android * Mobile - Add react-native-blur * Mobile - Mock @react-native-community/blur * Mobile - Update Podfile lock Co-authored-by: Pinar Olguc <pinarolguc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes wordpress-mobile/gutenberg-mobile#2326
gutenberg-mobile PR wordpress-mobile/gutenberg-mobile#2379
Target PR that is associated with the target branch
rnmobile/copy-duplicate-blocks: #23110This PR adds a Notice view to show some small, self-dismissing messages at the top of the page. Plus, integrates it with Copy, Cut events.
Colors: Same colors with Tooltip.
Timeout: 3secs before self dismissing
Height: 30px
Test:
After copying/cutting a block:
WPiOS:
WPAndroid:
Screenshots
👇👇👇
Click here to watch the video.
👆👆👆
Light Mode
Dark Mode
Checklist: