Skip to content

Image Block: add caption field to placeholder#22295

Merged
ellatrix merged 3 commits intomasterfrom
try/image-placeholder-caption
Jun 4, 2020
Merged

Image Block: add caption field to placeholder#22295
ellatrix merged 3 commits intomasterfrom
try/image-placeholder-caption

Conversation

@ellatrix
Copy link
Copy Markdown
Member

@ellatrix ellatrix commented May 12, 2020

Description

Fixes #22294.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 12, 2020 •
edited
Loading

Size Change: +1.13 kB (0%)

Total Size: 1.12 MB

Filename Size Change
build/annotations/index.js 3.62 kB -3 B (0%)
build/api-fetch/index.js 3.4 kB +2 B (0%)
build/autop/index.js 2.83 kB +1 B
build/block-directory/index.js 6.75 kB +7 B (0%)
build/block-editor/index.js 106 kB +42 B (0%)
build/block-editor/style-rtl.css 11.4 kB +12 B (0%)
build/block-editor/style.css 11.4 kB +10 B (0%)
build/block-library/index.js 126 kB +2 B (0%)
build/block-serialization-default-parser/index.js 1.88 kB +2 B (0%)
build/blocks/index.js 48.2 kB +12 B (0%)
build/components/index.js 193 kB +8 B (0%)
build/compose/index.js 9.31 kB -13 B (0%)
build/core-data/index.js 11.4 kB +14 B (0%)
build/data-controls/index.js 1.29 kB -1 B
build/data/index.js 8.46 kB +16 B (0%)
build/edit-post/index.js 302 kB +17 B (0%)
build/edit-site/index.js 15 kB +889 B (5%) 🔍
build/edit-widgets/index.js 8.83 kB +2 B (0%)
build/editor/index.js 44.7 kB +29 B (0%)
build/format-library/index.js 7.72 kB +3 B (0%)
build/hooks/index.js 2.13 kB -1 B
build/keyboard-shortcuts/index.js 2.52 kB +6 B (0%)
build/media-utils/index.js 5.3 kB +6 B (0%)
build/nux/index.js 3.4 kB +5 B (0%)
build/plugins/index.js 2.56 kB +2 B (0%)
build/rich-text/index.js 14.8 kB +14 B (0%)
build/server-side-render/index.js 2.68 kB +6 B (0%)
build/url/index.js 4.06 kB +40 B (0%)
build/viewport/index.js 1.85 kB +3 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/style-rtl.css 892 B 0 B
build/block-directory/style.css 892 B 0 B
build/block-library/editor-rtl.css 7.87 kB 0 B
build/block-library/editor.css 7.88 kB 0 B
build/block-library/style-rtl.css 7.69 kB 0 B
build/block-library/style.css 7.68 kB 0 B
build/block-library/theme-rtl.css 684 B 0 B
build/block-library/theme.css 686 B 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/components/style-rtl.css 19.5 kB 0 B
build/components/style.css 19.5 kB 0 B
build/date/index.js 5.47 kB 0 B
build/deprecated/index.js 771 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.11 kB 0 B
build/edit-navigation/index.js 8.25 kB 0 B
build/edit-navigation/style-rtl.css 878 B 0 B
build/edit-navigation/style.css 876 B 0 B
build/edit-post/style-rtl.css 5.43 kB 0 B
build/edit-post/style.css 5.43 kB 0 B
build/edit-site/style-rtl.css 2.96 kB 0 B
build/edit-site/style.css 2.96 kB 0 B
build/edit-widgets/style-rtl.css 2.4 kB 0 B
build/edit-widgets/style.css 2.4 kB 0 B
build/editor/editor-styles-rtl.css 425 B 0 B
build/editor/editor-styles.css 428 B 0 B
build/editor/style-rtl.css 4.26 kB 0 B
build/editor/style.css 4.27 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 711 B 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.12 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@ellatrix ellatrix force-pushed the try/image-placeholder-caption branch from 5adf663 to 9214bf4 Compare May 19, 2020 11:27
@ellatrix ellatrix force-pushed the try/image-placeholder-caption branch from 9214bf4 to e48fec7 Compare June 3, 2020 13:27
@ellatrix ellatrix requested review from nerrad and ntwb as code owners June 3, 2020 13:41
@ellatrix ellatrix force-pushed the try/image-placeholder-caption branch from 609f29d to 4369fd9 Compare June 3, 2020 20:53
@ellatrix ellatrix merged commit 2f1a8e7 into master Jun 4, 2020
@ellatrix ellatrix deleted the try/image-placeholder-caption branch June 4, 2020 15:13
@github-actions github-actions bot added this to the Gutenberg 8.3 milestone Jun 4, 2020
@Soean Soean mentioned this pull request Jun 7, 2020
Closed
@oandregal oandregal added the [Type] Enhancement A suggestion for improvement. label Jun 8, 2020
This was referenced Jun 8, 2020
Merged
Closed
@youknowriad
Copy link
Copy Markdown
Contributor

youknowriad commented Jun 8, 2020

This behavior has been raised here as problematic #21252 (comment)

It did seem a bit unexpected for me too. I'm on the fence.

@ellatrix
Copy link
Copy Markdown
Member Author

ellatrix commented Jun 8, 2020

Why is it problematic? It seems like the question raised is whether it can be moved to the top

@ellatrix
Copy link
Copy Markdown
Member Author

ellatrix commented Jun 8, 2020

Placeholders were added to Gutenberg so you could fill create and fill out some content while leaving other places black to fill in later. I believe this fits that vision?

@RickorDD
Copy link
Copy Markdown
Contributor

RickorDD commented Jun 8, 2020

Can we talk about this again in the next core-editor meeting next Wednesday?

ellatrix added a commit that referenced this pull request Jun 9, 2020
@ellatrix
Revert "Image Block: add caption field to placeholder (#22295)"
c32eafb 
This reverts commit 2f1a8e7.
@ellatrix ellatrix mentioned this pull request Jun 9, 2020
Merged
oandregal pushed a commit that referenced this pull request Jun 9, 2020
@ellatrix
Revert "Image Block: add caption field to placeholder (#22295)" (#23027)
a921fb3 
This reverts commit 2f1a8e7.
oandregal pushed a commit that referenced this pull request Jun 9, 2020
@ellatrix @oandregal
Revert "Image Block: add caption field to placeholder (#22295)" (#23027)
cbd8168 
This reverts commit 2f1a8e7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

@nerrad nerrad Awaiting requested review from nerrad

@ntwb ntwb Awaiting requested review from ntwb

Assignees

No one assigned

Labels

[Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

Gutenberg 8.3

Development

Successfully merging this pull request may close these issues.

Possibility to fill out caption before image upload

4 participants

@ellatrix @youknowriad @RickorDD @oandregal