Remove subscription button from blog template#22129
Merged
Conversation
Subscription Button doesn't have any functionality
2 tasks
|
Size Change: 0 B Total Size: 821 kB ℹ️ View Unchanged
|
geriux
approved these changes
May 6, 2020
Member
geriux
left a comment
There was a problem hiding this comment.
LGTM! Tested on both iOS and Android ✅
geriux
pushed a commit
that referenced
this pull request
May 6, 2020
Subscription Button doesn't have any functionality
geriux
pushed a commit
that referenced
this pull request
May 11, 2020
* Wrap button blocks with buttons blocks in mobile page templates * Remove subscription button (#22129) Subscription Button doesn't have any functionality Co-authored-by: Matthew Kevins <mmkevins@yahoo.com> Co-authored-by: Pinar Olguc <pinarolguc@gmail.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was brought up during beta testing. Subscription Button doesn't have any functionality so we are removing it from the Blog template.
gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#2219
Before:
After:
Checklist: