Skip to content

ESLint Plugin: Relax check for i18n-text-domain rule#21928

Merged
gziolo merged 1 commit intomasterfrom
fix/eslint-plugin-i18n-text-domain-relax
Apr 28, 2020
Merged

ESLint Plugin: Relax check for i18n-text-domain rule#21928
gziolo merged 1 commit intomasterfrom
fix/eslint-plugin-i18n-text-domain-relax

Conversation

@gziolo
Copy link
Copy Markdown
Member

@gziolo gziolo commented Apr 27, 2020

Description

Fixes #21920.

Tries the approach suggested by @swissspidy:

I think the easiest solution would be to remove the default text domain:

gutenberg/packages/eslint-plugin/rules/i18n-text-domain.js

Line 51 in 3b8965e

default: 'default',

gutenberg/packages/eslint-plugin/rules/i18n-text-domain.js

Line 71 in 3b8965e

const { allowedTextDomain = 'default' } = options;

So when the text domain is not explicitly specified (allowedTextDomain === undefined), the rule would do nothing

Now that I read it again, I want to double-check if we can bail early when the allowedTextDomain is not provided ... 🤣

How has this been tested?

npm run lint-js still works with Gutenberg – it uses local override

npm run lint-js doesn't fail when a random text domain is added to translations when the local override is removed.

npm run test-unit works with newly added unit tests.

@gziolo gziolo requested review from aduth and swissspidy April 27, 2020 15:29
@gziolo gziolo self-assigned this Apr 27, 2020
@gziolo gziolo added [Tool] ESLint plugin /packages/eslint-plugin [Type] Bug An existing feature does not function as intended labels Apr 27, 2020
@gziolo gziolo mentioned this pull request Apr 27, 2020
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 27, 2020

Size Change: 0 B

Total Size: 817 kB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.02 kB 0 B
build/annotations/index.js 3.62 kB 0 B
build/api-fetch/index.js 4.08 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.23 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 761 B 0 B
build/block-editor/index.js 106 kB 0 B
build/block-editor/style-rtl.css 10.2 kB 0 B
build/block-editor/style.css 10.2 kB 0 B
build/block-library/editor-rtl.css 7.03 kB 0 B
build/block-library/editor.css 7.03 kB 0 B
build/block-library/index.js 112 kB 0 B
build/block-library/style-rtl.css 7.14 kB 0 B
build/block-library/style.css 7.14 kB 0 B
build/block-library/theme-rtl.css 683 B 0 B
build/block-library/theme.css 685 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.1 kB 0 B
build/components/index.js 179 kB 0 B
build/components/style-rtl.css 16.9 kB 0 B
build/components/style.css 16.9 kB 0 B
build/compose/index.js 6.66 kB 0 B
build/core-data/index.js 11.4 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.42 kB 0 B
build/date/index.js 5.47 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.1 kB 0 B
build/edit-navigation/index.js 3.54 kB 0 B
build/edit-navigation/style-rtl.css 485 B 0 B
build/edit-navigation/style.css 485 B 0 B
build/edit-post/index.js 27.8 kB 0 B
build/edit-post/style-rtl.css 12.3 kB 0 B
build/edit-post/style.css 12.3 kB 0 B
build/edit-site/index.js 11 kB 0 B
build/edit-site/style-rtl.css 5.26 kB 0 B
build/edit-site/style.css 5.25 kB 0 B
build/edit-widgets/index.js 8.33 kB 0 B
build/edit-widgets/style-rtl.css 5 kB 0 B
build/edit-widgets/style.css 5 kB 0 B
build/editor/editor-styles-rtl.css 428 B 0 B
build/editor/editor-styles.css 431 B 0 B
build/editor/index.js 43.4 kB 0 B
build/editor/style-rtl.css 3.27 kB 0 B
build/editor/style.css 3.27 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.63 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.51 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.12 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 5.29 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.67 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/rich-text/index.js 14.8 kB 0 B
build/server-side-render/index.js 2.68 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.02 kB 0 B
build/viewport/index.js 1.84 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

@gziolo gziolo merged commit d89385f into master Apr 28, 2020
@gziolo gziolo deleted the fix/eslint-plugin-i18n-text-domain-relax branch April 28, 2020 11:45
@github-actions github-actions bot added this to the Gutenberg 8.1 milestone Apr 28, 2020
@aduth
Copy link
Copy Markdown
Member

aduth commented Apr 29, 2020

Probably should be a CHANGELOG.md entry for this?

@gziolo
Copy link
Copy Markdown
Member Author

gziolo commented Apr 29, 2020

Yes, an important one, thanks for catching 👍

gziolo added a commit that referenced this pull request Apr 30, 2020
@gziolo
Update CHANGELOG file for @wordpress/eslint-pluging
cbcb619 
Adds missing entry that was not included in #21928. Props to @aduth for noticing.
@gziolo
Copy link
Copy Markdown
Member Author

gziolo commented Apr 30, 2020

Done in cbcb619.

gziolo added a commit that referenced this pull request Apr 30, 2020
@gziolo
Update CHANGELOG file for @wordpress/eslint-pluging
3299a87 
Adds missing entry that was not included in #21928. Props to @aduth for noticing.
gziolo added a commit that referenced this pull request Apr 30, 2020
@gziolo
ESLint Plugin: Relax check for i18n-text-domain rule (#21928)
5395479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swissspidy swissspidy swissspidy approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@nerrad nerrad Awaiting requested review from nerrad

@ntwb ntwb Awaiting requested review from ntwb

@aduth aduth Awaiting requested review from aduth

Assignees

@gziolo gziolo

Labels

[Tool] ESLint plugin /packages/eslint-plugin [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

Gutenberg 8.1

Development

Successfully merging this pull request may close these issues.

i18n ESlint rules do not correctly default text-domain

3 participants

@gziolo @aduth @swissspidy