Add npm org scope to WordPress dependencies#2172
Merged
Conversation
youknowriad
approved these changes
Aug 3, 2017
Contributor
youknowriad
left a comment
There was a problem hiding this comment.
Awesome. Ship it, it works great 👍
Ensure loaded in correct order
8314260 to
cf5a450
Compare
Codecov Report
@@ Coverage Diff @@
## master #2172 +/- ##
=========================================
+ Coverage 22.15% 22.3% +0.14%
=========================================
Files 138 137 -1
Lines 4283 4291 +8
Branches 723 722 -1
=========================================
+ Hits 949 957 +8
- Misses 2814 2815 +1
+ Partials 520 519 -1
Continue to review full report at Codecov.
|
This was referenced Aug 3, 2017
Closed
Closed
Closed
Closed
Merged
nylen
added a commit
that referenced
this pull request
Aug 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #941
Related: #1205
This pull request seeks to add the WordPress npm organization scope to all WordPress dependency imports. It is a further realization of the intent for these top-level folders to be distributed as independent packages.
Other side-benefits include:
wp_register_scriptscript dependenciesImplementation notes:
This will be hellish to rebase, so I'd prefer not to let this one linger.
Testing instructions:
This is difficult to test because it touches nearly every file in the application. Verify through
npm run build,npm run dev,npm testthat no errors occur, and that no regressions or console errors occur by thorough use of the application.