Skip to content

eslint-plugin: fix: Cannot find module '../utils'#21609

Merged
aduth merged 1 commit intoWordPress:masterfrom
curtisbelt:fix/eslint-plugin-missing-utils
Apr 15, 2020
Merged

eslint-plugin: fix: Cannot find module '../utils'#21609
aduth merged 1 commit intoWordPress:masterfrom
curtisbelt:fix/eslint-plugin-missing-utils

Conversation

@curtisbelt
Copy link
Copy Markdown
Contributor

@curtisbelt curtisbelt commented Apr 15, 2020 •
edited
Loading

Description

Added utils to package.json "files" list. Without this, utils folder is missing, and you get an error when trying to run eslint: Error: Failed to load plugin '@wordpress/eslint-plugin' declared in '.eslintrc.js': Cannot find module '../utils'

Fixes #21610

@curtisbelt curtisbelt mentioned this pull request Apr 15, 2020
Closed
aduth
aduth approved these changes Apr 15, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 👍

@aduth aduth merged commit 5459d77 into WordPress:master Apr 15, 2020
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Apr 15, 2020
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 15, 2020

Congratulations on your first merged pull request, @curtisbelt! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 8.0 milestone Apr 15, 2020
@aduth
Copy link
Copy Markdown
Member

aduth commented Apr 15, 2020

I made a quick follow-up commit at f4c44cd to include a CHANGELOG entry for this fix, since it may be useful reference for those looking to upgrade after the fix is published.

gziolo pushed a commit that referenced this pull request Apr 15, 2020
@curtisbelt @gziolo
eslint-plugin: fix: Cannot find module '../utils' (#21609)
4d4f4e8
@gziolo
Copy link
Copy Markdown
Member

gziolo commented Apr 15, 2020

The new version 5.0.1 of the package is out on npm.

@marekdedic marekdedic mentioned this pull request Apr 16, 2020
Closed
@aduth aduth mentioned this pull request May 14, 2020
Merged
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduth aduth aduth approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@gziolo gziolo Awaiting requested review from gziolo

@nerrad nerrad Awaiting requested review from nerrad

@ntwb ntwb Awaiting requested review from ntwb

Assignees

No one assigned

Labels

First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository

Projects

None yet

Milestone

Gutenberg 8.0

Development

Successfully merging this pull request may close these issues.

eslint-config 5.0.0: Error: Failed to load plugin '@wordpress/eslint-plugin' declared in '.eslintrc.js': Cannot find module '../utils'

3 participants

@curtisbelt @aduth @gziolo