Improve the performance of the BlockPreview component#21574
Merged
youknowriad merged 1 commit intomasterfrom Apr 14, 2020
Merged
Improve the performance of the BlockPreview component#21574youknowriad merged 1 commit intomasterfrom
youknowriad merged 1 commit intomasterfrom
Conversation
|
Size Change: -30 B (0%) Total Size: 839 kB
ℹ️ View Unchanged
|
oandregal
approved these changes
Apr 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #21567
This PR fixes a performance issue on the BlockPreview component where it was being rerendered too often causing lags.
The issue was an old trick we were using with to recompute the preview, but that trick was only needed with the old implementation of the component.
Testing instructions