Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2141 +/- ##
==========================================
+ Coverage 20.33% 22.26% +1.92%
==========================================
Files 136 136
Lines 4274 4272 -2
Branches 724 721 -3
==========================================
+ Hits 869 951 +82
+ Misses 2872 2804 -68
+ Partials 533 517 -16
Continue to review full report at Codecov.
|
nylen
reviewed
Aug 1, 2017
Member
There was a problem hiding this comment.
Why not test the activeIndex after each of these keypresses?
Member
Author
There was a problem hiding this comment.
Why not test the
activeIndexafter each of these keypresses?
Good call. Updated in 366e98a.
afercia
approved these changes
Aug 2, 2017
Contributor
afercia
left a comment
There was a problem hiding this comment.
Tested keyboard interaction, looks good to me!
836f1c6 to
f40ae0d
Compare
Tug
pushed a commit
that referenced
this pull request
May 12, 2020
Co-Authored-By: Drapich Piotr <drapich.piotr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1975
This pull request seeks to...
onSelectprop (YAGNI)controlsprop exists before calling on itslengthproperty (since not a required prop)%operator for "reset to beginning" logicTesting instructions:
Verify that there are no regressions in the behavior of the Dropdown Menu, currently used only as the last control of the table block. Particularly with note of keyboard behaviors, recently refined in #1975.
Ensure that unit tests pass: