Skip to content

Update glossary.md#21367

Closed
machouinard wants to merge 1 commit intoWordPress:wp/5.4from
machouinard:patch-1
Closed

Update glossary.md#21367
machouinard wants to merge 1 commit intoWordPress:wp/5.4from
machouinard:patch-1

Conversation

@machouinard
Copy link
Copy Markdown
Contributor

@machouinard machouinard commented Apr 2, 2020

Remove duplicate sentence.

Description

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@machouinard
Update glossary.md
d0c2937 
Remove duplicate sentence.
Soean
Soean approved these changes Apr 3, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@Soean Soean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for the fix.

@swissspidy swissspidy added the [Type] Developer Documentation Documentation for developers label Apr 3, 2020
@mkaz
Copy link
Copy Markdown
Member

mkaz commented Apr 13, 2020

This needs to be rebased against master, it looks like it was opened against 5.4 tag.

@Soean
Copy link
Copy Markdown
Member

Soean commented Apr 13, 2020

@mkaz We had this issue on slack, see https://wordpress.slack.com/archives/C02QB2JS7/p1585897669457800

@machouinard
Copy link
Copy Markdown
Contributor Author

machouinard commented Apr 13, 2020

@mkaz We had this issue on slack, see https://wordpress.slack.com/archives/C02QB2JS7/p1585897669457800

Correct, that's where the link took me. I've since reset my fork to upstream/master but I'm happy to submit a new PR and reference this.

@mkaz
Copy link
Copy Markdown
Member

mkaz commented Apr 13, 2020

@machouinard Strange, it didn't seem to update here. I guess a PR is opened against where it wants to push too. So I think closing this one and opening new one might be best course of action.

@machouinard machouinard mentioned this pull request Apr 13, 2020
Merged
6 tasks
@machouinard
Copy link
Copy Markdown
Contributor Author

machouinard commented Apr 13, 2020 •
edited
Loading

@machouinard Strange, it didn't seem to update here. I guess a PR is opened against where it wants to push too. So I think closing this one and opening new one might be best course of action.

Created a fresh branch off master, pushed to my repo and opened PR. Guess I don't understand GitHub as well as I'd thought as it attached itself here (I mentioned it in the commit). Let me know if you need me to do anything differently.

mkaz pushed a commit that referenced this pull request Apr 13, 2020
@machouinard
Remove duplicate sentence. (#21565)
ce1a4d9 
In reference to #21367

Signed-off-by: Mark Chouinard <mark@chouinard.me>
@mkaz
Copy link
Copy Markdown
Member

mkaz commented Apr 13, 2020

Thanks @machouinard for creating the new one and moving the change. I approved and merged #21565, so closing this one out.

@mkaz mkaz closed this Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Soean Soean Soean approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

Assignees

No one assigned

Labels

[Type] Developer Documentation Documentation for developers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@machouinard @mkaz @Soean @swissspidy