Add pre to list of block wrappers#21255
Merged
ZebulanStanphill merged 7 commits intomasterfrom Mar 31, 2020
Merged
Conversation
|
Size Change: +9 B (0%) Total Size: 866 kB
ℹ️ View Unchanged
|
Contributor
|
👋 @SergioEstevao , this indeed fixes the issue but I wonder, do we need to keep a separate list of elements? Can't we have |
ZebulanStanphill
requested changes
Mar 30, 2020
packages/block-editor/src/components/block-list/block-elements.js
Outdated
Show resolved
Hide resolved
2 tasks
Contributor
|
This still looks good to me. @ZebulanStanphill , not sure if you'd like to make another pass now that your feedback has been addressed? In the meantime @SergioEstevao , looks like the PR needs updating since there's a merge conflict reported on the |
# Conflicts: # packages/block-editor/src/components/block-list/block-wrapper.js
Contributor
Author
|
@hypest conflict sorted. |
Member
ZebulanStanphill
left a comment
There was a problem hiding this comment.
One minor nitpick, but otherwise this looks good to me!
packages/block-editor/src/components/block-list/block-wrapper.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/block-list/block-wrapper.native.js
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@ZebulanStanphill ready for another look. |
etoledom
approved these changes
Mar 31, 2020
Contributor
etoledom
left a comment
There was a problem hiding this comment.
Looks good, works great, and all feedback seems to have been handled! 🎉
ZebulanStanphill
approved these changes
Mar 31, 2020
SergioEstevao
added a commit
that referenced
this pull request
Mar 31, 2020
* Add pre to list of block wrappers * Share the elements definition between web and native. * Make constant name all uppercase. * Rename constant name to be all uppercase * Rename elements constant to all uppercase
3 tasks
SergioEstevao
added a commit
that referenced
this pull request
Apr 3, 2020
…1352) * Revert revert of dark mode impl * Add pre to list of block wrappers (#21255) * Add pre to list of block wrappers * Share the elements definition between web and native. * Make constant name all uppercase. * Rename constant name to be all uppercase * Rename elements constant to all uppercase Co-authored-by: Marko Savic <savicmarko1985@gmail.com> Co-authored-by: Sérgio Estêvão <sergioestevao@gmail.com>
SergioEstevao
added a commit
that referenced
this pull request
Apr 3, 2020
…1352) * Revert revert of dark mode impl * Add pre to list of block wrappers (#21255) * Add pre to list of block wrappers * Share the elements definition between web and native. * Make constant name all uppercase. * Rename constant name to be all uppercase * Rename elements constant to all uppercase Co-authored-by: Marko Savic <savicmarko1985@gmail.com> Co-authored-by: Sérgio Estêvão <sergioestevao@gmail.com>
SergioEstevao
added a commit
that referenced
this pull request
Apr 3, 2020
* Add pre to list of block wrappers (#21255) * Add pre to list of block wrappers * Share the elements definition between web and native. * Make constant name all uppercase. * Rename constant name to be all uppercase * Rename elements constant to all uppercase * Fix the TS used for the GB-Mobile project. (#21324) * Fix the TS used for the GB-Mobile project. Make sure only types inside node_modules/@types are used. This avoids TS to find the ../node_modules/@types inside the gb-mobile repo that lives one path level up of gutenberg root. * Framework: Fix configuration spacing * Change to types node. * Revert "Change to types node." This reverts commit bfb8b7b. Co-authored-by: Andrew Duthie <andrew@andrewduthie.com> * [RNMobile] Dark mode on Android put on the v1.25.0 native release (#21352) * Revert revert of dark mode impl * Add pre to list of block wrappers (#21255) * Add pre to list of block wrappers * Share the elements definition between web and native. * Make constant name all uppercase. * Rename constant name to be all uppercase * Rename elements constant to all uppercase Co-authored-by: Marko Savic <savicmarko1985@gmail.com> Co-authored-by: Sérgio Estêvão <sergioestevao@gmail.com> Co-authored-by: Andrew Duthie <andrew@andrewduthie.com> Co-authored-by: Stefanos Togoulidis <stefanostogoulidis@gmail.com> Co-authored-by: Marko Savic <savicmarko1985@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add pre to the list of block wrappers in RN.
How has this been tested?
Using this Gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#2083
Types of changes
Checklist: