Categorize embeds for easier discovery#2123
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2123 +/- ##
==========================================
- Coverage 20.47% 20.43% -0.04%
==========================================
Files 135 135
Lines 4245 4243 -2
Branches 724 723 -1
==========================================
- Hits 869 867 -2
Misses 2844 2844
Partials 532 532
Continue to review full report at Codecov.
|
| { slug: 'layout', title: __( 'Layout Blocks' ) }, | ||
| { slug: 'widgets', title: __( 'Widgets' ) }, | ||
| { slug: 'embed', title: __( 'Embed' ) }, | ||
| { slug: 'embed-common', title: __( 'Common' ) }, |
There was a problem hiding this comment.
Probably not... Although this is just for getting feedback on the UX at this point :)
|
Hello again @notnownikki! Any chance you could add a screenshot to this issue... I'm sorry for my lame designer head that is afraid of reading code :-) |
|
I really like this @notnownikki. My only wonder is 'Blogs and Documents' and if there is something better to categorise there. I think it's worth merging though (once the conflict has been resolved). For reference this is what it looks like:
|
|
@karmatosed thank you for screenshotting that. @annaephox I'm really sorry for not putting up screenshots, it was exclusionary of me, and I apoligize for making it difficult for you to give feedback. I won't make that mistake again. ❤️ I'll clean up the conflicts on those branches and gif/screenshot next week after the public holiday here :) |
|
@notnownikki Any plans for this PR? |
|
Unless anyone thinks there's a pressing need for this, I'm happy to close it. I think adding the extra search keywords to blocks makes them easier to find and I haven't seen anyone wanting to revisit this in a while. |
|
Ok, let's close for now and see if it comes up again. Thanks @notnownikki |
…keyboard Layout Picker - Keyboard visibility improvements
No description provided.