Move block server-side logic into same directory as client-side logic#2014
Merged
westonruter merged 4 commits intomasterfrom Jul 31, 2017
Merged
Move block server-side logic into same directory as client-side logic#2014westonruter merged 4 commits intomasterfrom
westonruter merged 4 commits intomasterfrom
Conversation
aduth
requested changes
Jul 26, 2017
Member
aduth
left a comment
There was a problem hiding this comment.
See also: #1095
We need to remove this line:
https://github.com/WordPress/gutenberg/blob/44ad46a/bin/build-plugin-zip.sh#L71
And ensure that block PHP files are included in the generated plugin.
b1b056d to
bfe31c2
Compare
Member
Author
Codecov Report
@@ Coverage Diff @@
## master #2014 +/- ##
==========================================
+ Coverage 20.21% 20.37% +0.16%
==========================================
Files 135 135
Lines 4225 4490 +265
Branches 717 802 +85
==========================================
+ Hits 854 915 +61
- Misses 2842 2970 +128
- Partials 529 605 +76
Continue to review full report at Codecov.
|
aduth
approved these changes
Jul 31, 2017
Member
aduth
left a comment
There was a problem hiding this comment.
Verified package plugin loads block correctly.
Verified composer lint surfaces issues in the block PHP file.
| require_once dirname( __FILE__ ) . '/lib/parser.php'; | ||
| require_once dirname( __FILE__ ) . '/lib/register.php'; | ||
|
|
||
| // Register server-side code for individual blocks. |
This was referenced Jul 31, 2017
Closed
Tug
pushed a commit
that referenced
this pull request
Mar 19, 2020
…new-block-indicator-style Update 'Add Block Here' indicator style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working with dynamic blocks it is not ideal for the JS and PHP logic to be separated out in two separate locations. Ideally the dynamic block server rendering logic as well as unit tests could be placed right inside of the same directory as the client logic.
This would also impact the Latest Comments block: #1931.