Try: Add component for handling keyboard events#1944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1850
Supersedes #1908
Related: #1943
This pull request explores adding a new
KeyboardEventscomponent to assist in handling keyboard events.See full README.md documentation
Implementation notes:
Currently, it is implemented to capture keyboard events globally, but I expect this could be further enhanced in the future to add scoping to a specific element context by optionally supporting
childrenofKeyboardShortcuts, where a combination ofref,findDOMNode, andrenderedNode.contains( event.target )confirms that the keyboard event occurred within the rendered children.Testing instructions:
Verify that there is no regression in "Select All" keyboard behavior (#1211).