Skip to content

[RNMobile] - Implements Dark Mode on Android platform#19293

Merged
marecar3 merged 21 commits intomasterfrom
rnmobile/dark_mode_android_integration
Mar 19, 2020
Merged

[RNMobile] - Implements Dark Mode on Android platform#19293
marecar3 merged 21 commits intomasterfrom
rnmobile/dark_mode_android_integration

Conversation

@marecar3
Copy link
Copy Markdown
Contributor

@marecar3 marecar3 commented Dec 21, 2019 •
edited
Loading

Description

Implements dark mode on Android platform: wordpress-mobile/gutenberg-mobile#1675

How has this been tested?

Instructions can be found on the following gb-mobile PR: wordpress-mobile/gutenberg-mobile#1717

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@marecar3 marecar3 mentioned this pull request Dec 21, 2019
Merged
3 tasks
@marecar3 marecar3 changed the title Create android specific index file for preferred color scheme [RNMobile] - Implements dark mode on Android platform Dec 21, 2019
@marecar3 marecar3 changed the title [RNMobile] - Implements dark mode on Android platform [RNMobile] - Implements Dark Mode on Android platform Dec 21, 2019
@marecar3 marecar3 marked this pull request as ready for review December 25, 2019 16:21
@marecar3 marecar3 added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Dec 25, 2019
@marecar3 marecar3 requested review from cameronvoell and removed request for hypest and maxme February 6, 2020 12:48
etoledom
etoledom approved these changes Feb 17, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We could probably use this same strategy on iOS to move away from react-native-dark-mode in the future.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 10, 2020 •
edited
Loading

Size Change: 0 B

Total Size: 856 kB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.01 kB 0 B
build/annotations/index.js 3.43 kB 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/autop/index.js 2.58 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.02 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-editor/index.js 100 kB 0 B
build/block-editor/style-rtl.css 10.7 kB 0 B
build/block-editor/style.css 10.7 kB 0 B
build/block-library/editor-rtl.css 7.23 kB 0 B
build/block-library/editor.css 7.24 kB 0 B
build/block-library/index.js 111 kB 0 B
build/block-library/style-rtl.css 7.38 kB 0 B
build/block-library/style.css 7.39 kB 0 B
build/block-library/theme-rtl.css 669 B 0 B
build/block-library/theme.css 671 B 0 B
build/block-serialization-default-parser/index.js 1.65 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 57.7 kB 0 B
build/components/index.js 191 kB 0 B
build/components/style-rtl.css 15.5 kB 0 B
build/components/style.css 15.5 kB 0 B
build/compose/index.js 5.76 kB 0 B
build/core-data/index.js 10.6 kB 0 B
build/data-controls/index.js 1.04 kB 0 B
build/data/index.js 8.21 kB 0 B
build/date/index.js 5.37 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.06 kB 0 B
build/edit-post/index.js 91.3 kB 0 B
build/edit-post/style-rtl.css 8.64 kB 0 B
build/edit-post/style.css 8.64 kB 0 B
build/edit-site/index.js 4.64 kB 0 B
build/edit-site/style-rtl.css 2.48 kB 0 B
build/edit-site/style.css 2.48 kB 0 B
build/edit-widgets/index.js 4.45 kB 0 B
build/edit-widgets/style-rtl.css 2.58 kB 0 B
build/edit-widgets/style.css 2.58 kB 0 B
build/editor/editor-styles-rtl.css 381 B 0 B
build/editor/editor-styles.css 382 B 0 B
build/editor/index.js 43.8 kB 0 B
build/editor/style-rtl.css 3.97 kB 0 B
build/editor/style.css 3.96 kB 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.09 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 1.92 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.49 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.3 kB 0 B
build/keycodes/index.js 1.68 kB 0 B
build/list-reusable-blocks/index.js 2.99 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 4.85 kB 0 B
build/notices/index.js 1.57 kB 0 B
build/nux/index.js 3.01 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.54 kB 0 B
build/primitives/index.js 1.49 kB 0 B
build/priority-queue/index.js 779 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/rich-text/index.js 14.3 kB 0 B
build/server-side-render/index.js 2.55 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.01 kB 0 B
build/viewport/index.js 1.61 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

@marecar3 marecar3 merged commit 78e749d into master Mar 19, 2020
@marecar3 marecar3 deleted the rnmobile/dark_mode_android_integration branch March 19, 2020 08:10
@github-actions github-actions bot added this to the Gutenberg 7.8 milestone Mar 19, 2020
marecar3 added a commit that referenced this pull request Mar 24, 2020
@marecar3
Revert "[RNMobile] - Implements Dark Mode on Android platform (#19293)"
43ce820 
This reverts commit 78e749d.
This was referenced Mar 24, 2020
Merged
Merged
jbinda added a commit that referenced this pull request Mar 24, 2020
@jbinda
Revert "[RNMobile] - Implements Dark Mode on Android platform (#19293)"
17b46ba 
This reverts commit 78e749d.
aduth pushed a commit that referenced this pull request Mar 24, 2020
@marecar3
Revert "[RNMobile] - Implements Dark Mode on Android platform (#19293)…
1631335 
…" (#21113)

This reverts commit 78e749d.
@marecar3 marecar3 mentioned this pull request Mar 25, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etoledom etoledom etoledom approved these changes

@mchowning mchowning Awaiting requested review from mchowning

@cameronvoell cameronvoell Awaiting requested review from cameronvoell

Assignees

No one assigned

Labels

Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)

Projects

None yet

Milestone

Gutenberg 7.8

Development

Successfully merging this pull request may close these issues.

2 participants

@marecar3 @etoledom