[RNMobile] Avoid setting alignSelf for image placeholders#18793
Merged
[RNMobile] Avoid setting alignSelf for image placeholders#18793
Conversation
This was causing the placeholders to not display
1 task
etoledom
approved these changes
Dec 17, 2019
Contributor
etoledom
left a comment
There was a problem hiding this comment.
Works as expected!
Thank you @mchowning 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes wordpress-mobile/gutenberg-mobile#1592, where image placeholders would not be shown if there was a failure downloading an aligned image. This was caused by the setting of the
alignSelfattribute. Since that attribute is not being used for the placeholder, only setting it when an image is present fixes the issue.Related gutenberg-mobile PR
Checklist: