RNMobile: Remove unneeded/duplicate css#18759
Conversation
maxme
left a comment
There was a problem hiding this comment.
Changes look good when tested in the wpandroid and wpios, or in the example app. Thanks for looking into that @mchowning
| @@ -1,3 +1,5 @@ | |||
| $floating-toolbar-height: 44; | |||
There was a problem hiding this comment.
Note: I checked we only used this one here.
| value={ attributes.content } | ||
| style={ { | ||
| ...style, | ||
| minHeight: styles[ 'wp-block-heading' ].minHeight, |
There was a problem hiding this comment.
I wonder why we had that in the first place. I searched the file history, and unfortunately it comes from a big merge. Maybe @Tug knows better if this is safe to change.
There was a problem hiding this comment.
Yeah it comes from this PR (related gb-mobile PR).
From what I understand it was used to fix a bug/inconsistency in Aztec related to the placeholder not being displayed when no content was given. I'm not sure if this has been fixed in Aztec, maybe @marecar3 knows? Otherwise @mchowning might have tested it and made sure that was not an issue before removing it?
There was a problem hiding this comment.
Just double-checked and the placeholders are showing up for headings, paragraphs, etc. for me.
|
Note a recent PR #18155 for |
Tested and it looks like that |
maxme
left a comment
There was a problem hiding this comment.
LGTM 
- I'll update the gb-mobile PR
29bf5ff to
b0dd531
Compare
b0dd531 to
0337520
Compare
Description
This is some css cleanup that was included as a part of the fix for wordpress-mobile/gutenberg-mobile#992 in https://github.com/wordpress-mobile/gutenberg-mobile/pull/1560/files.
How has this been tested?
Inusure that the following components display properly with no excess padding:
Checklist: