[RNmobile] Bring Placeholder text back working on Heading blocks#14404
Merged
daniloercoli merged 7 commits intornmobile/developfrom Mar 14, 2019
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does remove the temporary fix introduced in #14301, that disabled placeholder text on heading blocks, and bring it back on Heading and other textual blocks.
The PR mentioned above was introduced to fix an issue where Heading was not properly styled when started typing in the field.
To test this PR follow the instructions in the gb-mobile PR available here: wordpress-mobile/gutenberg-mobile#739