Skip to content

Remove clearing the block selection on sidebar tab switch#18621

Merged
talldan merged 1 commit into
masterfrom
try/keep-block-selection-on-document-tab
Dec 3, 2019
Merged

Remove clearing the block selection on sidebar tab switch#18621
talldan merged 1 commit into
masterfrom
try/keep-block-selection-on-document-tab

Conversation

@draganescu

@draganescu draganescu commented Nov 20, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Closes #18239

How has this been tested?

Tested locally.

Screenshots

no-selection-clearing

Types of changes

It is a simple update of the settings-header that removes the call to clearSelectedBlock.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@draganescu draganescu requested a review from talldan as a code owner November 20, 2019 06:56
@draganescu draganescu added [Package] Block editor /packages/block-editor [Type] Enhancement A suggestion for improvement. labels Nov 20, 2019
@draganescu draganescu self-assigned this Nov 20, 2019
@draganescu draganescu added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility labels Nov 20, 2019
jorgefilipecosta
jorgefilipecosta reviewed Nov 22, 2019
View reviewed changes

@jorgefilipecosta jorgefilipecosta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this works as expected from the code point of view. But I would wait on feedback from @jasmussen as the original author of #6887 before merging.

@jasmussen

jasmussen commented Nov 22, 2019

Copy link
Copy Markdown
Contributor

Thanks. I've shared with Andrei that I think this is one of those things that, if it's a trivial amount of code, we can just go ahead and try it. I'm still not convinced it's actually preferable behavior, but if we merge and dislike, we can always revert. So no blockers from me!

jorgefilipecosta
jorgefilipecosta approved these changes Nov 22, 2019
View reviewed changes

@jorgefilipecosta jorgefilipecosta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@talldan talldan merged commit a06542d into master Dec 3, 2019
@talldan talldan deleted the try/keep-block-selection-on-document-tab branch December 3, 2019 07:15
glendaviesnz pushed a commit to Automattic/wp-calypso that referenced this pull request Dec 4, 2019
Update test to match new gutenberg behaviour of selection not being c…
edb3460 
…leared when toggling sidebar - WordPress/gutenberg#18621
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
@draganescu draganescu mentioned this pull request Dec 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorgefilipecosta jorgefilipecosta jorgefilipecosta approved these changes
@talldan talldan Awaiting requested review from talldan

Assignees

@draganescu draganescu

Labels

[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility [Package] Block editor /packages/block-editor [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

Gutenberg 7.1

Development

Successfully merging this pull request may close these issues.

Preserve selection when switching block editor tabs

5 participants

@draganescu @jasmussen @jorgefilipecosta @youknowriad @talldan