Skip to content

[Experimental] Cross platform Box component to replace View#17673

Closed
dratwas wants to merge 27 commits intoWordPress:rnmobile/masterfrom
callstack:experimental/mobile/styled-components
Closed

[Experimental] Cross platform Box component to replace View#17673
dratwas wants to merge 27 commits intoWordPress:rnmobile/masterfrom
callstack:experimental/mobile/styled-components

Conversation

@dratwas
Copy link
Copy Markdown
Contributor

@dratwas dratwas commented Oct 1, 2019

Description

This is a continuation of experimental PR with styled-system + styled-components to check cross-platform styling possibilities.
This is a mobile part
More info here - wordpress-mobile/gutenberg-mobile#1386
PR with web changes - #17614
GB-mobile PR - wordpress-mobile/gutenberg-mobile#1395

How has this been tested?

Check if everything is rendered properly in the video block

Screenshots

video not selected

Screenshot 2019-10-01 at 14 19 08

video selected

Screenshot 2019-10-01 at 14 19 40

no video

Screenshot 2019-10-01 at 14 20 04

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@dratwas dratwas changed the title [WIP]Experimental/mobile/styled components [Experimental] Cross platform Box component to replace View Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants