-
Notifications
You must be signed in to change notification settings - Fork 57
Styled System exploration for Cross Platform components #1386
Copy link
Copy link
Closed
Labels
Description
Let's explore styled-system to see how it can be useful for designing cross platform primitives.
For this exploration we can use a CSS-in-JS library such as Styled Components. Although it is optional and if there's a better one feel free to use that one.
What should be done?
- Introduce a
Boxcomponent to replace div/View. - Layout and styling of the
Boxcomponent should be possible via props. We shouldn't pass className to it, instead all the CSS will be hidden insideBox. - Replace
divusages in gutenberg/packages/block-library/src/gallery/gallery-image.js withBoxkeeping the same look. - Lastly remove unused CSS lines.
Here's a branch with some already done work, let's checkout a new branch from this branch and keep working based on this: WordPress/gutenberg@rnmobile/master...experimental/styled-system-poc the branch still uses old way of getting up the development environment so npm run dev will still work for now. If at some point we need to update it from master we should refer to the updated guidelines.
Reactions are currently unavailable