Project automation: Rewrite actions using JavaScript by noisysocks · Pull Request #17080 · WordPress/gutenberg

noisysocks · 2019-08-19T02:15:56Z

Replaces all of our Docker container actions with a single JavaScript action.

This has a few benefits:

Easier to understand: Gutenberg is primarily a JavaScript application, and we're all primarily JavaScript developers, so it makes sense to use what we know.
More performant: According to the docs, JavaScript actions run faster than Docker container actions.
Testable: We can use our existing jest setup to write unit tests for our actions.
Less noise: By replacing 3 actions with 1 action, we'll have 1/3 as many 'checks' appear at the bottom of each PR.

Docs: https://help.github.com/en/categories/automating-your-workflow-with-github-actions

.github/workflows/pull-request-automation.yml

noisysocks · 2019-08-19T05:45:45Z

Yay, it works!

I'm pretty happy with where this is at, although I'd like to remove the npm install and npm run build:packages steps since they're so slow.

What do you think, @talldan?

talldan · 2019-08-19T06:34:40Z

package.json

 	},
 	"devDependencies": {
+		"@actions/core": "1.0.0",
+		"@actions/github": "1.0.0",


Hmm, I wouldn't have thought these dependencies were needed in the root package.json.

According to https://github.com/WordPress/gutenberg/blob/4665d7074dfeae43eac02b1d2e4ad5713832078e/packages/README.md#development-dependencies it's intended that way.

Thanks for the pointer @swissspidy.

But these are also listed as dependencies in packages/project-management-automation/package.json . Surely they don't need to be declared twice? They seem more appropriate as dependencies to me than as devDependencies, since they're required for the runtime script of the module.

packages/pull-request-automation/src/add-first-time-contributor-label.js

packages/pull-request-automation/src/assign-fixed-issues.js

packages/pull-request-automation/src/index.js

talldan

Love this, introduces a really nice scaffolding to add more automation to PRs, and ensures there won't be any extra noise if we do. ❤️

I'd be happy to see it merged and have smaller follow up PRs address the comments.

packages/pull-request-automation/src/index.js

youknowriad

Nice work here 🎉

…omation

noisysocks · 2019-08-22T04:34:11Z

@talldan @youknowriad: Pretty happy with this now! Have moved a few things around so will need another review.

I renamed the package from pull-request-automation to project-management-automation in anticipation of future tasks that might do more than just manage pull requests.
I'm running npm install inside the action's directory which makes the action run a lot faster.
I removed Babel transpilation from the package which makes the action run a lot faster.
I added lots of logging which should help us work out out what's going wrong/on.
I refactored the code that invokes our different tasks so that it's easier to add new ones.
I fixed a mistake where I was looking at context.action instead of context.payload.action 🙄

.github/workflows/pull-request-automation.yml

talldan

Double approving!

* Project automation: Rewrite actions using JavaScript * Project automation: Don't transpile or install all dependencies * Project automation: pull-request-automation -> project-management-automation * Project automation: Add explanatory comment for `npm install` hack * Project automation: Add debug statements * Project automation: Don't use GitHub's debug() function * Project automation: Use `payload` in tasks, not `context` * Project automation: Link to the relevant GitHub documentation

into rnmobile/add-autosave-to-mobile * 'rnmobile/master' of https://github.com/WordPress/gutenberg: (52 commits) [RNMobile] DarkMode improvements (#17309) Remove redundant bg color within button appender (#17325) Support group block on mobile (#17251) [RNMobile] Insure tapping at end of post inserts at end Recover border colors (#17269) [RNMobile] Fix dismiss keyboard button for the post title (#17260) Unify media placeholder and upload props within media-text (#17268) MediaUpload and MediaPlaceholder unify props (#17145) Add native support for the MediaText block (#16305) Activate Travis CI on rnmobile/master branch (#17229) [RNMobile] Native mobile release v1.11.0 (#17181) Apply box-sizing border-box properly to the notices components (#17066) Writing Flow: allow undo of patterns with BACKSPACE and ESC (#14776) Project automation: Rewrite actions using JavaScript (#17080) Build: remove global install of latest npm since we want to use the paired node/npm version (#17134) Writing Flow/Quote: allow splitting (#17121) Use `400` as a valid `font-weight` Add: Disabled block count in the block manager (#17103) Update video player style on mobile - Add a new gridicon play icon, from: https://github.com/Automattic/gridicons/blob/87c9fce08b4a9f184b9fb4963228757fdd4f4e74/svg-min/gridicons-play.svg - Replace the Dashicon play by this one - Update icon size and icon color - Update the overlay color [RNMobile] Hide replaceable block when adding block (#16931) ... # Conflicts: # packages/block-editor/src/components/block-list/index.native.js # packages/block-editor/src/components/inserter/index.native.js # packages/block-editor/src/components/inserter/menu.native.js # packages/block-editor/src/components/media-placeholder/index.native.js # packages/block-editor/src/components/warning/index.native.js # packages/block-library/src/code/edit.native.js # packages/block-library/src/image/edit.native.js # packages/block-library/src/missing/edit.native.js # packages/block-library/src/more/edit.native.js # packages/block-library/src/nextpage/edit.native.js # packages/block-library/src/video/edit.native.js # packages/components/src/mobile/bottom-sheet/cell.native.js # packages/components/src/mobile/bottom-sheet/index.native.js # packages/components/src/mobile/dark-mode/index.native.js # packages/components/src/mobile/html-text-input/index.native.js # packages/components/src/toolbar/toolbar-container.native.js # packages/edit-post/src/components/header/header-toolbar/index.native.js # packages/edit-post/src/components/layout/index.native.js # packages/edit-post/src/components/visual-editor/index.native.js # packages/rich-text/src/component/index.native.js

noisysocks added the [Type] Project Management Meta-issues related to project management of Gutenberg label Aug 19, 2019

noisysocks requested a review from talldan August 19, 2019 02:15

noisysocks requested review from ajitbohra, chrisvanpatten, karmatosed, mapk and youknowriad as code owners August 19, 2019 02:15

noisysocks changed the title ~~GitHub Actions: Rewrite actions using JavaScript~~ Project automation: Rewrite actions using JavaScript Aug 19, 2019

Project automation: Rewrite actions using JavaScript

d4ca647

noisysocks force-pushed the update/use-javascript-actions branch from 21cbdad to d4ca647 Compare August 19, 2019 05:30

noisysocks commented Aug 19, 2019

View reviewed changes

.github/workflows/pull-request-automation.yml Outdated Show resolved Hide resolved

noisysocks commented Aug 19, 2019

View reviewed changes

.github/workflows/pull-request-automation.yml Outdated Show resolved Hide resolved

talldan reviewed Aug 19, 2019

View reviewed changes

packages/pull-request-automation/src/add-first-time-contributor-label.js Outdated Show resolved Hide resolved

talldan reviewed Aug 19, 2019

View reviewed changes

packages/pull-request-automation/src/assign-fixed-issues.js Outdated Show resolved Hide resolved

talldan reviewed Aug 19, 2019

View reviewed changes

packages/pull-request-automation/src/index.js Outdated Show resolved Hide resolved

talldan approved these changes Aug 19, 2019

View reviewed changes

youknowriad reviewed Aug 19, 2019

View reviewed changes

packages/pull-request-automation/src/index.js Outdated Show resolved Hide resolved

youknowriad reviewed Aug 19, 2019

View reviewed changes

Project automation: Don't transpile or install all dependencies

3c22f92

noisysocks force-pushed the update/use-javascript-actions branch from c2ed9f9 to 3c22f92 Compare August 22, 2019 02:23

noisysocks added 6 commits August 22, 2019 12:38

Project automation: pull-request-automation -> project-management-aut…

6a61e2b

…omation

Project automation: Add explanatory comment for npm install hack

64db4d2

Project automation: Add debug statements

c22a98e

Project automation: Don't use GitHub's debug() function

2b81c7a

Project automation: Use payload in tasks, not context

1117288

Project automation: Link to the relevant GitHub documentation

ec84e96

talldan reviewed Aug 22, 2019

View reviewed changes

.github/workflows/pull-request-automation.yml Show resolved Hide resolved

talldan approved these changes Aug 22, 2019

View reviewed changes

noisysocks merged commit 47dfd82 into master Aug 22, 2019

noisysocks deleted the update/use-javascript-actions branch August 22, 2019 05:02

swissspidy mentioned this pull request Aug 23, 2019

Project Management Automation using GitHub Actions ampproject/amp-wp#2741

Closed

aduth mentioned this pull request Jan 18, 2020

Project Management: Run pull request automation on closed #19742

Merged

aduth mentioned this pull request Feb 3, 2020

Project Management Automation: Tolerate duplicate milestone #20011

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Project automation: Rewrite actions using JavaScript#17080

Project automation: Rewrite actions using JavaScript#17080
noisysocks merged 8 commits intomasterfrom
update/use-javascript-actions

noisysocks commented Aug 19, 2019

Uh oh!

Uh oh!

Uh oh!

noisysocks commented Aug 19, 2019

Uh oh!

talldan Aug 19, 2019

Uh oh!

swissspidy Aug 19, 2019

Uh oh!

talldan Aug 20, 2019

Uh oh!

aduth Dec 1, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

talldan left a comment

Uh oh!

Uh oh!

youknowriad left a comment

Uh oh!

noisysocks commented Aug 22, 2019 •

edited

Loading

Uh oh!

Uh oh!

talldan left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

noisysocks commented Aug 19, 2019

Uh oh!

Uh oh!

Uh oh!

noisysocks commented Aug 19, 2019

Uh oh!

talldan Aug 19, 2019

Choose a reason for hiding this comment

Uh oh!

swissspidy Aug 19, 2019

Choose a reason for hiding this comment

Uh oh!

talldan Aug 20, 2019

Choose a reason for hiding this comment

Uh oh!

aduth Dec 1, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

talldan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

youknowriad left a comment

Choose a reason for hiding this comment

Uh oh!

noisysocks commented Aug 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

talldan left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

noisysocks commented Aug 22, 2019 •

edited

Loading